Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 04:53:13PM +0300, Nikolay Shirokovskiy wrote: > > > On 17.11.2017 16:47, Daniel P. Berrange wrote: > > On Fri, Nov 17, 2017 at 04:45:27PM +0300, Nikolay Shirokovskiy wrote: > > Ah I see. I think this smells like a bug in the tests/Makefile.am > > Ahh, this is fixed upstre

Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Nikolay Shirokovskiy
On 17.11.2017 16:47, Daniel P. Berrange wrote: > On Fri, Nov 17, 2017 at 04:45:27PM +0300, Nikolay Shirokovskiy wrote: >> >> >> On 17.11.2017 16:40, Daniel P. Berrange wrote: >>> On Fri, Nov 17, 2017 at 04:31:13PM +0300, Nikolay Shirokovskiy wrote: On 17.11.2017 16:24, Daniel P. Be

Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 04:45:27PM +0300, Nikolay Shirokovskiy wrote: > > > On 17.11.2017 16:40, Daniel P. Berrange wrote: > > On Fri, Nov 17, 2017 at 04:31:13PM +0300, Nikolay Shirokovskiy wrote: > >> > >> > >> On 17.11.2017 16:24, Daniel P. Berrange wrote: > >>> On Fri, Nov 17, 2017 at 04:17:37

Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Nikolay Shirokovskiy
On 17.11.2017 16:40, Daniel P. Berrange wrote: > On Fri, Nov 17, 2017 at 04:31:13PM +0300, Nikolay Shirokovskiy wrote: >> >> >> On 17.11.2017 16:24, Daniel P. Berrange wrote: >>> On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote: If one of the libraries is compiled with tc

Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 04:31:13PM +0300, Nikolay Shirokovskiy wrote: > > > On 17.11.2017 16:24, Daniel P. Berrange wrote: > > On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote: > >> If one of the libraries is compiled with tcmalloc then > >> the latter will add GLIBCPP_FORCE_N

Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Nikolay Shirokovskiy
On 17.11.2017 16:24, Daniel P. Berrange wrote: > On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote: >> If one of the libraries is compiled with tcmalloc then >> the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to >> environment at startup and thus break commandtest.

Re: [libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Daniel P. Berrange
On Fri, Nov 17, 2017 at 04:17:37PM +0300, Nikolay Shirokovskiy wrote: > If one of the libraries is compiled with tcmalloc then > the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to > environment at startup and thus break commandtest. How are they getting those envs into our environment

[libvirt] [PATCH 1/2] tests: commandtest: handle tcmalloc hacking environment

2017-11-17 Thread Nikolay Shirokovskiy
If one of the libraries is compiled with tcmalloc then the latter will add GLIBCPP_FORCE_NEW and GLIBCXX_FORCE_NEW to environment at startup and thus break commandtest. --- tests/commandhelper.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/commandhelper.c b