On 07/10/2018 03:34 PM, Han Han wrote:
> Sorry, it should be virFileCdromStatus not virFileCdromState :)
Yes, that makes sense.
Also, please do not top post on technical lists. It's common to either
reply in line or at the bottom.
Michal
--
libvir-list mailing list
libvir-list@redhat.com
https:
Sorry, it should be virFileCdromStatus not virFileCdromState :)
On Tue, Jul 10, 2018 at 9:28 PM, Han Han wrote:
> Hello Michel,
> I agree with you that we could integrate these two APIs into one. If so, I
> think we should change the API name virFileIsCDROM to **virFileCheckCDROM**
> or **virFil
Hello Michel,
I agree with you that we could integrate these two APIs into one. If so, I
think we should change the API name virFileIsCDROM to **virFileCheckCDROM**
or **virFileCdromState**. virFileIsCDROM is confusing and doesn't indicate
the function of checking state.
On Tue, Jul 10, 2018 at 3:
Thank u for reviewing. I will give patch v2 later.
On Tue, Jul 10, 2018 at 2:38 PM, Michal Privoznik
wrote:
> On 07/03/2018 04:29 AM, Han Han wrote:
> > This private API helps check cdrom drive status via ioctl().
> >
> > Signed-off-by: Han Han
> > ---
> > src/libvirt_private.syms | 1 +
> >
On 07/03/2018 04:29 AM, Han Han wrote:
> This private API helps check cdrom drive status via ioctl().
>
> Signed-off-by: Han Han
> ---
> src/libvirt_private.syms | 1 +
> src/util/virfile.c | 52
> src/util/virfile.h | 10
> 3 files
This private API helps check cdrom drive status via ioctl().
Signed-off-by: Han Han
---
src/libvirt_private.syms | 1 +
src/util/virfile.c | 52
src/util/virfile.h | 10
3 files changed, 63 insertions(+)
diff --git a/src/libvirt_pri
