Re: [libvirt] [PATCH 1/3] iscsi: Check for presence of error before creating new one

2015-03-31 Thread Ján Tomko
On Mon, Mar 30, 2015 at 07:16:32PM -0400, John Ferlan wrote: If virStorageBackendSCSIFindLUs fails, but the failure has an error message - the iscsi code didn't honor that creating it's own wonderful message such as error: Failed to find LUs on host 60: ... - not overly helpful. Since a few of

Re: [libvirt] [PATCH 1/3] iscsi: Check for presence of error before creating new one

2015-03-31 Thread John Ferlan
On 03/31/2015 07:03 AM, Ján Tomko wrote: On Mon, Mar 30, 2015 at 07:16:32PM -0400, John Ferlan wrote: If virStorageBackendSCSIFindLUs fails, but the failure has an error message - the iscsi code didn't honor that creating it's own wonderful message such as error: Failed to find LUs on host

[libvirt] [PATCH 1/3] iscsi: Check for presence of error before creating new one

2015-03-30 Thread John Ferlan
If virStorageBackendSCSIFindLUs fails, but the failure has an error message - the iscsi code didn't honor that creating it's own wonderful message such as error: Failed to find LUs on host 60: ... - not overly helpful. Since a few of the called paths generate a message, check for that before using