Re: [libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

2016-06-30 Thread Marc Hartmayer
On Thu, Jun 30, 2016 at 12:34 PM +0200, Peter Krempa wrote: >> qemuDomainObjPrivatePtr priv = vm->privateData; >> +virDomainControllerDefPtr cont = NULL; > > This variable isn't necessary. >> +/* Let's make sure the disk has a controller defined and loaded before

Re: [libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

2016-06-30 Thread Kashyap Chamarthy
On Mon, Jun 27, 2016 at 04:43:46PM +0200, Marc Hartmayer wrote: > The commit "qemu: hot-plug: Assume support for -device in > qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI > controller creation used in SCSI disk hot-plugging. If we are > hot-plugging a SCSI disk to a domain and

Re: [libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

2016-06-30 Thread Peter Krempa
On Mon, Jun 27, 2016 at 16:43:46 +0200, Marc Hartmayer wrote: > The commit "qemu: hot-plug: Assume support for -device in > qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI > controller creation used in SCSI disk hot-plugging. If we are > hot-plugging a SCSI disk to a domain and

Re: [libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

2016-06-30 Thread Daniel P. Berrange
On Mon, Jun 27, 2016 at 04:43:46PM +0200, Marc Hartmayer wrote: > The commit "qemu: hot-plug: Assume support for -device in > qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI > controller creation used in SCSI disk hot-plugging. If we are > hot-plugging a SCSI disk to a domain and

[libvirt] [PATCH 1/3] qemu: hot-plug: Fix broken SCSI disk hot-plug

2016-06-27 Thread Marc Hartmayer
The commit "qemu: hot-plug: Assume support for -device in qemuDomainAttachSCSIDisk" dropped the code for the automatic SCSI controller creation used in SCSI disk hot-plugging. If we are hot-plugging a SCSI disk to a domain and there is no proper SCSI controller defined, it results in an "error: