Re: [libvirt] [PATCH 1/3] tests: Tweak cputest_LDADDS

2019-06-12 Thread Jim Fehlig
On 6/12/19 5:19 AM, Andrea Bolognani wrote: We want have all test programs using qemu_LDADDS also use LDADDS, This part of the sentence seems awkward. How about "We want all test programs using qemu_LDADDS to also use LDADDS," ? and cputest is the only existing exception. We can't just

[libvirt] [PATCH 1/3] tests: Tweak cputest_LDADDS

2019-06-12 Thread Andrea Bolognani
We want have all test programs using qemu_LDADDS also use LDADDS, and cputest is the only existing exception. We can't just replace GNULIB_LIBS with LDADDS though, even though the latter is a superset of the former, because that would result in a linking error due to including the same object