Re: [libvirt] [PATCH 1/3] utils: Implement virCommandPassFDGetFDIndex

2015-02-25 Thread Martin Kletzander
On Wed, Feb 25, 2015 at 06:03:40AM -0700, Eric Blake wrote: On 02/24/2015 09:52 PM, Martin Kletzander wrote: The problem of having to prevent the reordering of file descriptors when we are building the QEMU command line with file descriptors already exists today. So maybe I could just remove

Re: [libvirt] [PATCH 1/3] utils: Implement virCommandPassFDGetFDIndex

2015-02-25 Thread Eric Blake
On 02/24/2015 09:52 PM, Martin Kletzander wrote: The problem of having to prevent the reordering of file descriptors when we are building the QEMU command line with file descriptors already exists today. So maybe I could just remove this flag and the related check knowing that reordering of

Re: [libvirt] [PATCH 1/3] utils: Implement virCommandPassFDGetFDIndex

2015-02-25 Thread Stefan Berger
On 02/24/2015 11:52 PM, Martin Kletzander wrote: On Tue, Feb 24, 2015 at 09:24:51AM -0500, Stefan Berger wrote: On 02/24/2015 08:34 AM, Martin Kletzander wrote: On Mon, Feb 23, 2015 at 06:50:46AM -0500, Stefan Berger wrote: Implement virCommandPassFDGetFDIndex to determine the index a given

Re: [libvirt] [PATCH 1/3] utils: Implement virCommandPassFDGetFDIndex

2015-02-24 Thread Martin Kletzander
On Mon, Feb 23, 2015 at 06:50:46AM -0500, Stefan Berger wrote: Implement virCommandPassFDGetFDIndex to determine the index a given file descriptor will have when passed to the child process. When this function is called, a flag is set to prevent the reordering of the file descriptors.

Re: [libvirt] [PATCH 1/3] utils: Implement virCommandPassFDGetFDIndex

2015-02-24 Thread Stefan Berger
On 02/24/2015 08:34 AM, Martin Kletzander wrote: On Mon, Feb 23, 2015 at 06:50:46AM -0500, Stefan Berger wrote: Implement virCommandPassFDGetFDIndex to determine the index a given file descriptor will have when passed to the child process. When this function is called, a flag is set to prevent

Re: [libvirt] [PATCH 1/3] utils: Implement virCommandPassFDGetFDIndex

2015-02-24 Thread Martin Kletzander
On Tue, Feb 24, 2015 at 09:24:51AM -0500, Stefan Berger wrote: On 02/24/2015 08:34 AM, Martin Kletzander wrote: On Mon, Feb 23, 2015 at 06:50:46AM -0500, Stefan Berger wrote: Implement virCommandPassFDGetFDIndex to determine the index a given file descriptor will have when passed to the child

[libvirt] [PATCH 1/3] utils: Implement virCommandPassFDGetFDIndex

2015-02-23 Thread Stefan Berger
Implement virCommandPassFDGetFDIndex to determine the index a given file descriptor will have when passed to the child process. When this function is called, a flag is set to prevent the reordering of the file descriptors. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com ---