Re: [libvirt] [PATCH 1/3] vbox: fix incorrect loop condition in vboxHostDeviceGetXMLDesc

2013-12-01 Thread Daniel Veillard
ACK looks the right thing to do indeed, thanks, Daniel On Sun, Dec 01, 2013 at 11:46:05PM +0900, Ryota Ozaki wrote: > The fixed loop used logical OR to combine two conditions, however, > it is apparently incorrect and logical AND is correct. > > We can fix it by replacing OR with AND, but

[libvirt] [PATCH 1/3] vbox: fix incorrect loop condition in vboxHostDeviceGetXMLDesc

2013-12-01 Thread Ryota Ozaki
The fixed loop used logical OR to combine two conditions, however, it is apparently incorrect and logical AND is correct. We can fix it by replacing OR with AND, but this patch instead fixes the problem by getting rid of the first conditional statement: USBFilterCount < def->nhostdevs. It isn't ne