Re: [libvirt] [PATCH 1/4] util: introduce a new helper for get interface IPv6 address

2015-02-27 Thread lhuang
On 02/25/2015 11:55 PM, Laine Stump wrote: On 02/25/2015 04:50 AM, lhuang wrote: And i also thought about another issue after your reminding: An interface can have more than one IPv6 address. But i still couldn't find a good way until now to chose which IPv6 address if we find more than one

Re: [libvirt] [PATCH 1/4] util: introduce a new helper for get interface IPv6 address

2015-02-26 Thread lhuang
On 02/25/2015 11:55 PM, Laine Stump wrote: On 02/25/2015 04:50 AM, lhuang wrote: And i also thought about another issue after your reminding: An interface can have more than one IPv6 address. But i still couldn't find a good way until now to chose which IPv6 address if we find more than one

Re: [libvirt] [PATCH 1/4] util: introduce a new helper for get interface IPv6 address

2015-02-25 Thread lhuang
On 02/25/2015 12:12 AM, John Ferlan wrote: On 02/13/2015 02:17 AM, Luyao Huang wrote: Introduce a new function to help to get interface IPv6 address. s/Introduce a new function to help to/Introduce virNetDevGetIPv6Address/ Signed-off-by: Luyao Huang lhu...@redhat.com ---

Re: [libvirt] [PATCH 1/4] util: introduce a new helper for get interface IPv6 address

2015-02-25 Thread lhuang
On 02/25/2015 01:42 AM, John Ferlan wrote: On 02/24/2015 11:12 AM, John Ferlan wrote: ...snip... As I'm reading the next patch I'm thinking I forgot something in the previous one... The default has been IPv4 and would seem to be the right thing to return once we find an address; however, if

Re: [libvirt] [PATCH 1/4] util: introduce a new helper for get interface IPv6 address

2015-02-24 Thread John Ferlan
On 02/13/2015 02:17 AM, Luyao Huang wrote: Introduce a new function to help to get interface IPv6 address. s/Introduce a new function to help to/Introduce virNetDevGetIPv6Address/ Signed-off-by: Luyao Huang lhu...@redhat.com --- src/libvirt_private.syms | 1 + src/util/virnetdev.c

Re: [libvirt] [PATCH 1/4] util: introduce a new helper for get interface IPv6 address

2015-02-24 Thread John Ferlan
On 02/24/2015 11:12 AM, John Ferlan wrote: ...snip... As I'm reading the next patch I'm thinking I forgot something in the previous one... The default has been IPv4 and would seem to be the right thing to return once we find an address; however, if we wanted an IPv6 address and returned an

[libvirt] [PATCH 1/4] util: introduce a new helper for get interface IPv6 address

2015-02-12 Thread Luyao Huang
Introduce a new function to help to get interface IPv6 address. Signed-off-by: Luyao Huang lhu...@redhat.com --- src/libvirt_private.syms | 1 + src/util/virnetdev.c | 70 src/util/virnetdev.h | 2 ++ 3 files changed, 73 insertions(+)