Re: [libvirt] [PATCH 1/5] tests: qemuxml2argvmock: Don't mock virCommandPassFD

2018-08-16 Thread Peter Krempa
On Thu, Aug 16, 2018 at 12:08:12 +0200, Michal Privoznik wrote: > On 08/14/2018 03:21 PM, Peter Krempa wrote: > > This function does not modify the host. It merely puts the file > > descriptor into a list in virCommandPtr. > > > > Signed-off-by: Peter Krempa > > --- > > tests/qemuxml2argvmock.c

Re: [libvirt] [PATCH 1/5] tests: qemuxml2argvmock: Don't mock virCommandPassFD

2018-08-16 Thread Michal Privoznik
On 08/14/2018 03:21 PM, Peter Krempa wrote: > This function does not modify the host. It merely puts the file > descriptor into a list in virCommandPtr. > > Signed-off-by: Peter Krempa > --- > tests/qemuxml2argvmock.c | 8 > 1 file changed, 8 deletions(-) > > diff --git

Re: [libvirt] [PATCH 1/5] tests: qemuxml2argvmock: Don't mock virCommandPassFD

2018-08-14 Thread Daniel P . Berrangé
On Tue, Aug 14, 2018 at 03:21:06PM +0200, Peter Krempa wrote: > This function does not modify the host. It merely puts the file > descriptor into a list in virCommandPtr. Yes & no. It doesn't directly modify the host, but my adding the FD to 'passfd' set, when virCommandFree is run later, it

[libvirt] [PATCH 1/5] tests: qemuxml2argvmock: Don't mock virCommandPassFD

2018-08-14 Thread Peter Krempa
This function does not modify the host. It merely puts the file descriptor into a list in virCommandPtr. Signed-off-by: Peter Krempa --- tests/qemuxml2argvmock.c | 8 1 file changed, 8 deletions(-) diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c index