Re: [libvirt] [PATCH 1/8] Remove superfluous usage of virDomainDeviceInfoNeedsFormat

2017-08-01 Thread John Ferlan
On 07/26/2017 09:29 AM, Ján Tomko wrote: > This function returns false if virDomainDeviceInfoFormat > would not format anything. > > Using it as the sole condition to decide whether to call > virDomainDeviceInfoFormat or not is pointless, since > the conditions are repeated in

[libvirt] [PATCH 1/8] Remove superfluous usage of virDomainDeviceInfoNeedsFormat

2017-07-26 Thread Ján Tomko
This function returns false if virDomainDeviceInfoFormat would not format anything. Using it as the sole condition to decide whether to call virDomainDeviceInfoFormat or not is pointless, since the conditions are repeated in virDomainDeviceInfoFormat. --- src/conf/domain_conf.c | 33