Re: [libvirt] [PATCH 11/12] src: replace gmtime_r/localtime_r/strftime with GDateTime

2020-01-15 Thread Ján Tomko
On Tue, Jan 14, 2020 at 04:22:39PM +0100, Pavel Hrdina wrote: On Fri, Jan 10, 2020 at 03:41:15PM +, Daniel P. Berrangé wrote: gmtime_r/localtime_r are mostly used in combination with strftime to format timestamps in libvirt. This can all be replaced with GDateTime resulting in simpler code

Re: [libvirt] [PATCH 11/12] src: replace gmtime_r/localtime_r/strftime with GDateTime

2020-01-14 Thread Pavel Hrdina
On Fri, Jan 10, 2020 at 03:41:15PM +, Daniel P. Berrangé wrote: > gmtime_r/localtime_r are mostly used in combination with > strftime to format timestamps in libvirt. This can all > be replaced with GDateTime resulting in simpler code > that is also more portable. > > There is some boundary

[libvirt] [PATCH 11/12] src: replace gmtime_r/localtime_r/strftime with GDateTime

2020-01-10 Thread Daniel P . Berrangé
gmtime_r/localtime_r are mostly used in combination with strftime to format timestamps in libvirt. This can all be replaced with GDateTime resulting in simpler code that is also more portable. There is some boundary condition problem in parsing POSIX timezone offsets in GLib which tickles our