Re: [libvirt] [PATCH 13/26] qemu: Resolve Coverity FORWARD_NULL

2014-09-11 Thread Peter Krempa
On 09/05/14 00:26, John Ferlan wrote: > If the virJSONValueNewObject() fails, then rather than going to error > and getting a Coverity false positive since it doesn't seem to understand > the relationship between nkeywords, keywords, and values and seems to > believe calling qemuFreeKeywords will c

Re: [libvirt] [PATCH 13/26] qemu: Resolve Coverity FORWARD_NULL

2014-09-09 Thread John Ferlan
On 09/09/2014 03:36 AM, Wang Rui wrote: > On 2014/9/5 6:26, John Ferlan wrote: >> If the virJSONValueNewObject() fails, then rather than going to error >> and getting a Coverity false positive since it doesn't seem to understand >> the relationship between nkeywords, keywords, and values and seem

Re: [libvirt] [PATCH 13/26] qemu: Resolve Coverity FORWARD_NULL

2014-09-09 Thread Wang Rui
On 2014/9/5 6:26, John Ferlan wrote: > If the virJSONValueNewObject() fails, then rather than going to error > and getting a Coverity false positive since it doesn't seem to understand > the relationship between nkeywords, keywords, and values and seems to > believe calling qemuFreeKeywords will ca

[libvirt] [PATCH 13/26] qemu: Resolve Coverity FORWARD_NULL

2014-09-04 Thread John Ferlan
If the virJSONValueNewObject() fails, then rather than going to error and getting a Coverity false positive since it doesn't seem to understand the relationship between nkeywords, keywords, and values and seems to believe calling qemuFreeKeywords will cause a NULL deref - just return NULL Signed-o