Re: [libvirt] [PATCH 15/18] virhostdev: Unify virHostdevPreparePCIDevices behaviour for KVM and VFIO cases

2019-08-16 Thread Daniel Henrique Barboza
Reviewed-by: Daniel Henrique Barboza On 8/14/19 8:57 AM, Michal Privoznik wrote: The virHostdevPreparePCIDevices() function works in several steps. In the very first one, it checks if devices we want to detach from the host are not taken already by some other domain. However, this piece of

Re: [libvirt] [PATCH 15/18] virhostdev: Unify virHostdevPreparePCIDevices behaviour for KVM and VFIO cases

2019-08-16 Thread Daniel Henrique Barboza
On 8/16/19 5:59 AM, Michal Privoznik wrote: On 8/14/19 6:14 PM, Daniel Henrique Barboza wrote: Michal, I believe the problem you're trying to fix in this patch is somehow the same I'm trying to fix in this patch here: https://www.redhat.com/archives/libvir-list/2019-June/msg01270.html Do

Re: [libvirt] [PATCH 15/18] virhostdev: Unify virHostdevPreparePCIDevices behaviour for KVM and VFIO cases

2019-08-16 Thread Michal Privoznik
On 8/14/19 6:14 PM, Daniel Henrique Barboza wrote: Michal, I believe the problem you're trying to fix in this patch is somehow the same I'm trying to fix in this patch here: https://www.redhat.com/archives/libvir-list/2019-June/msg01270.html Do you mind taking a look? If that's the case, I

Re: [libvirt] [PATCH 15/18] virhostdev: Unify virHostdevPreparePCIDevices behaviour for KVM and VFIO cases

2019-08-14 Thread Daniel Henrique Barboza
Michal, I believe the problem you're trying to fix in this patch is somehow the same I'm trying to fix in this patch here: https://www.redhat.com/archives/libvir-list/2019-June/msg01270.html Do you mind taking a look? If that's the case, I can drop that patch from the series that implements

[libvirt] [PATCH 15/18] virhostdev: Unify virHostdevPreparePCIDevices behaviour for KVM and VFIO cases

2019-08-14 Thread Michal Privoznik
The virHostdevPreparePCIDevices() function works in several steps. In the very first one, it checks if devices we want to detach from the host are not taken already by some other domain. However, this piece of code returns different results depending on the stub driver used (which is not wrong per