Re: [libvirt] [PATCH 2/2] python: Expose binding for virNodeGetMemoryStats()

2011-12-05 Thread Peter Krempa
On 12/02/2011 06:23 PM, Eric Blake wrote: Copy and paste, so not a problem with this patch any more so than the other functions that used the same code pattern, but can PyDict_SetItem fail? If so, should be be reclaiming the entries added so far before returning overall failure, instead of

Re: [libvirt] [PATCH 2/2] python: Expose binding for virNodeGetMemoryStats()

2011-12-02 Thread Peter Krempa
Dňa 2.12.2011 18:23, Eric Blake wrote / napísal(a): On 11/28/2011 10:19 AM, Peter Krempa wrote: +if (!(ret = PyDict_New())) { +free(stats); +return VIR_PY_NONE; +} +for (i = 0; i nparams; i++) { +PyDict_SetItem(ret, +

[libvirt] [PATCH 2/2] python: Expose binding for virNodeGetMemoryStats()

2011-11-28 Thread Peter Krempa
This patch adds binding for virNodeGetMemoryStats method of libvirtd. Return value is represended as a python dictionary mapping fileld names to values. --- include/libvirt/libvirt.h.in|6 +++- python/libvirt-override-api.xml |7 + python/libvirt-override.c | 48