Re: [libvirt] [PATCH 2/2] qemu: Always use iohelper for dumping domain core

2012-02-07 Thread Jiri Denemark
On Mon, Feb 06, 2012 at 15:43:59 -0700, Eric Blake wrote: On 02/06/2012 07:51 AM, Jiri Denemark wrote: Qemu uses non-blocking I/O which doesn't play nice with regular file descriptors. We need to pass a pipe to qemu instead, which can easily be done using iohelper. ---

Re: [libvirt] [PATCH 2/2] qemu: Always use iohelper for dumping domain core

2012-02-07 Thread Eric Blake
On 02/07/2012 05:09 AM, Jiri Denemark wrote: On Mon, Feb 06, 2012 at 15:43:59 -0700, Eric Blake wrote: On 02/06/2012 07:51 AM, Jiri Denemark wrote: Qemu uses non-blocking I/O which doesn't play nice with regular file descriptors. We need to pass a pipe to qemu instead, which can easily be

Re: [libvirt] [PATCH 2/2] qemu: Always use iohelper for dumping domain core

2012-02-07 Thread Jiri Denemark
On Tue, Feb 07, 2012 at 14:35:44 -0700, Eric Blake wrote: There are two situations where we save to file - one during core dump (which, as you point out, can be live where the guest continues to run after the dump, and therefore must be interruptible), and one during 'virsh save' or 'virsh

[libvirt] [PATCH 2/2] qemu: Always use iohelper for dumping domain core

2012-02-06 Thread Jiri Denemark
Qemu uses non-blocking I/O which doesn't play nice with regular file descriptors. We need to pass a pipe to qemu instead, which can easily be done using iohelper. --- src/qemu/qemu_driver.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c

Re: [libvirt] [PATCH 2/2] qemu: Always use iohelper for dumping domain core

2012-02-06 Thread Eric Blake
On 02/06/2012 07:51 AM, Jiri Denemark wrote: Qemu uses non-blocking I/O which doesn't play nice with regular file descriptors. We need to pass a pipe to qemu instead, which can easily be done using iohelper. --- src/qemu/qemu_driver.c |3 +-- 1 files changed, 1 insertions(+), 2