Re: [libvirt] [PATCH 2/2] qemu: Check for job being set when getting iothread stats

On 11/8/19 4:05 PM, Jonathon Jongsma wrote: On Fri, 2019-11-08 at 10:44 +0100, Michal Privoznik wrote: On 11/7/19 6:29 PM, Jonathon Jongsma wrote: On Thu, 2019-11-07 at 14:19 +0100, Michal Privoznik wrote: The qemuDomainGetStatsIOThread() accesses the monitor by calling

Re: [libvirt] [PATCH 2/2] qemu: Check for job being set when getting iothread stats

On Fri, 2019-11-08 at 10:44 +0100, Michal Privoznik wrote: > On 11/7/19 6:29 PM, Jonathon Jongsma wrote: > > On Thu, 2019-11-07 at 14:19 +0100, Michal Privoznik wrote: > > > The qemuDomainGetStatsIOThread() accesses the monitor by calling > > > qemuDomainGetIOThreadsMon(). And it's also marked as

Re: [libvirt] [PATCH 2/2] qemu: Check for job being set when getting iothread stats

On 11/7/19 6:29 PM, Jonathon Jongsma wrote: On Thu, 2019-11-07 at 14:19 +0100, Michal Privoznik wrote: The qemuDomainGetStatsIOThread() accesses the monitor by calling qemuDomainGetIOThreadsMon(). And it's also marked as "need monitor" in qemuDomainGetStatsWorkers[]. However, it's not checking

Re: [libvirt] [PATCH 2/2] qemu: Check for job being set when getting iothread stats

On Thu, 2019-11-07 at 14:19 +0100, Michal Privoznik wrote: > The qemuDomainGetStatsIOThread() accesses the monitor by calling > qemuDomainGetIOThreadsMon(). And it's also marked as "need > monitor" in qemuDomainGetStatsWorkers[]. However, it's not > checking if acquiring job was successful. > >

[libvirt] [PATCH 2/2] qemu: Check for job being set when getting iothread stats

The qemuDomainGetStatsIOThread() accesses the monitor by calling qemuDomainGetIOThreadsMon(). And it's also marked as "need monitor" in qemuDomainGetStatsWorkers[]. However, it's not checking if acquiring job was successful. Signed-off-by: Michal Privoznik --- src/qemu/qemu_driver.c | 4 ++-- 1