Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

2017-02-22 Thread Peter Krempa
On Wed, Feb 22, 2017 at 10:34:12 +0100, Peter Krempa wrote: > On Mon, Feb 13, 2017 at 23:53:43 +0100, Tomáš Golembiovský wrote: > > The 'raw' block driver in Qemu is not directly interesting from > > libvirt's perspective, but it can be layered above some other block > > drivers and this may be

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

2017-02-22 Thread Peter Krempa
On Mon, Feb 13, 2017 at 23:53:43 +0100, Tomáš Golembiovský wrote: > The 'raw' block driver in Qemu is not directly interesting from > libvirt's perspective, but it can be layered above some other block > drivers and this may be interesting for the user. > > The patch adds support for the 'raw'

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

2017-02-15 Thread Richard W.M. Jones
On Wed, Feb 15, 2017 at 12:53:39PM +0100, Tomáš Golembiovský wrote: > On Wed, 15 Feb 2017 10:55:24 + > "Richard W.M. Jones" wrote: > > > On Tue, Feb 14, 2017 at 10:03:54PM +0100, Tomáš Golembiovský wrote: > > > Hi, > > > > > > On Tue, 14 Feb 2017 15:58:45 + > > >

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

2017-02-15 Thread Tomáš Golembiovský
On Wed, 15 Feb 2017 10:55:24 + "Richard W.M. Jones" wrote: > On Tue, Feb 14, 2017 at 10:03:54PM +0100, Tomáš Golembiovský wrote: > > Hi, > > > > On Tue, 14 Feb 2017 15:58:45 + > > "Richard W.M. Jones" wrote: > > > > > The patches compile. > > >

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

2017-02-15 Thread Richard W.M. Jones
On Tue, Feb 14, 2017 at 10:03:54PM +0100, Tomáš Golembiovský wrote: > Hi, > > On Tue, 14 Feb 2017 15:58:45 + > "Richard W.M. Jones" wrote: > > > The patches compile. > > > > I looked at both commits and they at least superficially seem > > sensible. I'm not intimately

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

2017-02-14 Thread Tomáš Golembiovský
Hi, On Tue, 14 Feb 2017 15:58:45 + "Richard W.M. Jones" wrote: > The patches compile. > > I looked at both commits and they at least superficially seem > sensible. I'm not intimately familiar enough with the original code > to review this fully. > > However I want to

Re: [libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

2017-02-14 Thread Richard W.M. Jones
The patches compile. I looked at both commits and they at least superficially seem sensible. I'm not intimately familiar enough with the original code to review this fully. However I want to try to test this using libguestfs. I believe the following test case should be sufficient: $ cd

[libvirt] [PATCH 2/2] util: storage: add JSON backing volume parser 'raw' block driver

2017-02-13 Thread Tomáš Golembiovský
The 'raw' block driver in Qemu is not directly interesting from libvirt's perspective, but it can be layered above some other block drivers and this may be interesting for the user. The patch adds support for the 'raw' block driver. The driver is treated simply as a pass-through and child driver