Re: [libvirt] [PATCH 2/3] Debug: Remove unnecessary errors reported while parsing non-existent sysfs files.

2017-03-22 Thread Peter Krempa
On Wed, Mar 22, 2017 at 14:13:25 +0530, Prerna wrote: > I agree. Thanks for pointing out that this is a behavioural change, which > should not happen. Please don't top post on technical lists. > > I should be doing something like this: > > if (virFileReadAllQuiet(path, 1024, ) < 0 ) { >

Re: [libvirt] [PATCH 2/3] Debug: Remove unnecessary errors reported while parsing non-existent sysfs files.

2017-03-22 Thread Prerna
I agree. Thanks for pointing out that this is a behavioural change, which should not happen. I should be doing something like this: if (virFileReadAllQuiet(path, 1024, ) < 0 ) { if (errno != ENOENT) { virReportSystemError(errno, _("unable to read:

Re: [libvirt] [PATCH 2/3] Debug: Remove unnecessary errors reported while parsing non-existent sysfs files.

2017-03-22 Thread Peter Krempa
On Wed, Mar 22, 2017 at 09:14:41 +0100, Peter Krempa wrote: > On Wed, Mar 22, 2017 at 01:02:18 -0700, Prerna Saxena wrote: > > Sample from current logs: > > error : virFileReadAll:1290 : Failed to open file > > '/sys/class/net/tap3/operstate': No such file or directory > > error :

Re: [libvirt] [PATCH 2/3] Debug: Remove unnecessary errors reported while parsing non-existent sysfs files.

2017-03-22 Thread Peter Krempa
On Wed, Mar 22, 2017 at 01:02:18 -0700, Prerna Saxena wrote: > Sample from current logs: > error : virFileReadAll:1290 : Failed to open file > '/sys/class/net/tap3/operstate': No such file or directory > error : virNetDevGetLinkInfo:1895 : unable to read: > /sys/class/net/tap3/operstate: No such

[libvirt] [PATCH 2/3] Debug: Remove unnecessary errors reported while parsing non-existent sysfs files.

2017-03-22 Thread Prerna Saxena
Sample from current logs: error : virFileReadAll:1290 : Failed to open file '/sys/class/net/tap3/operstate': No such file or directory error : virNetDevGetLinkInfo:1895 : unable to read: /sys/class/net/tap3/operstate: No such file or directory These have no useful data point and are redundant.