Re: [libvirt] [PATCH 2/3] qemu: consolidate parameters of qemuBuildChrChardevStr into flags

2018-07-05 Thread Daniel P . Berrangé
On Thu, Jul 05, 2018 at 02:43:18PM +0200, Michal Prívozník wrote: > On 07/05/2018 01:36 PM, Daniel P. Berrangé wrote: > > There are two boolean parameters passed to qemuBuildChrChardevStr, > > and soon there will be a third. It will be clearer to understand > > from callers' POV if we use named

Re: [libvirt] [PATCH 2/3] qemu: consolidate parameters of qemuBuildChrChardevStr into flags

2018-07-05 Thread Michal Prívozník
On 07/05/2018 01:36 PM, Daniel P. Berrangé wrote: > There are two boolean parameters passed to qemuBuildChrChardevStr, > and soon there will be a third. It will be clearer to understand > from callers' POV if we use named flags instead. > > Signed-off-by: Daniel P. Berrangé > --- >

[libvirt] [PATCH 2/3] qemu: consolidate parameters of qemuBuildChrChardevStr into flags

2018-07-05 Thread Daniel P . Berrangé
There are two boolean parameters passed to qemuBuildChrChardevStr, and soon there will be a third. It will be clearer to understand from callers' POV if we use named flags instead. Signed-off-by: Daniel P. Berrangé --- src/qemu/qemu_command.c | 86 ++--- 1