Re: [libvirt] [PATCH 2/3] qemu: migration: error if tunnelled + storage specified

2013-05-30 Thread Michal Privoznik
On 29.05.2013 21:37, Cole Robinson wrote: On 05/29/2013 03:16 PM, Michal Privoznik wrote: On 28.05.2013 22:44, Cole Robinson wrote: Since as the code indicates it doesn't work yet, so let's be explicit about it. --- src/qemu/qemu_migration.c | 24 ++-- 1 file changed,

Re: [libvirt] [PATCH 2/3] qemu: migration: error if tunnelled + storage specified

2013-05-29 Thread Michal Privoznik
On 28.05.2013 22:44, Cole Robinson wrote: Since as the code indicates it doesn't work yet, so let's be explicit about it. --- src/qemu/qemu_migration.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_migration.c

Re: [libvirt] [PATCH 2/3] qemu: migration: error if tunnelled + storage specified

2013-05-29 Thread Cole Robinson
On 05/29/2013 03:16 PM, Michal Privoznik wrote: On 28.05.2013 22:44, Cole Robinson wrote: Since as the code indicates it doesn't work yet, so let's be explicit about it. --- src/qemu/qemu_migration.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff

[libvirt] [PATCH 2/3] qemu: migration: error if tunnelled + storage specified

2013-05-28 Thread Cole Robinson
Since as the code indicates it doesn't work yet, so let's be explicit about it. --- src/qemu/qemu_migration.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 9ac9be4..ffc86a4 100644 ---

Re: [libvirt] [PATCH 2/3] qemu: migration: error if tunnelled + storage specified

2013-05-28 Thread Eric Blake
On 05/28/2013 02:44 PM, Cole Robinson wrote: Since as the code indicates it doesn't work yet, so let's be explicit about it. --- src/qemu/qemu_migration.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) ACK. An explicit error is always nicer than a nebulous