Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-28 Thread Daniel P. Berrange
On Sun, Oct 25, 2009 at 10:54:19PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 05:15:26PM +0200, Dan Kenigsberg wrote: Just stumpbled on another issue: On Tue, Sep 29, 2009 at 04:43:50PM +0100, Daniel P. Berrange wrote: @@ -366,6 +367,13 @@ struct _virDomainGraphicsDef {

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-28 Thread Dan Kenigsberg
On Wed, Oct 28, 2009 at 07:57:05PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 10:54:19PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 05:15:26PM +0200, Dan Kenigsberg wrote: Just stumpbled on another issue: On Tue, Sep 29, 2009 at 04:43:50PM +0100, Daniel P.

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-28 Thread Hugh O. Brock
On Wed, Oct 28, 2009 at 10:53:48PM +0200, Dan Kenigsberg wrote: On Wed, Oct 28, 2009 at 07:57:05PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 10:54:19PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 05:15:26PM +0200, Dan Kenigsberg wrote: Just stumpbled on

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-28 Thread Dan Kenigsberg
On Wed, Oct 28, 2009 at 05:01:48PM -0400, Hugh O. Brock wrote: On Wed, Oct 28, 2009 at 10:53:48PM +0200, Dan Kenigsberg wrote: On Wed, Oct 28, 2009 at 07:57:05PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at 10:54:19PM +, Daniel P. Berrange wrote: On Sun, Oct 25, 2009 at

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-25 Thread Dan Kenigsberg
Just stumpbled on another issue: On Tue, Sep 29, 2009 at 04:43:50PM +0100, Daniel P. Berrange wrote: @@ -366,6 +367,13 @@ struct _virDomainGraphicsDef { char *display; int fullscreen : 1; } desktop; +struct { +int port; +

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-25 Thread Daniel P. Berrange
On Sun, Oct 25, 2009 at 05:15:26PM +0200, Dan Kenigsberg wrote: Just stumpbled on another issue: On Tue, Sep 29, 2009 at 04:43:50PM +0100, Daniel P. Berrange wrote: @@ -366,6 +367,13 @@ struct _virDomainGraphicsDef { char *display; int fullscreen : 1;

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-19 Thread Dan Kenigsberg
Thanks for the patches (and sorry for the late response). The patches are fine, though I am still missing a means to control which of spice channels are to be encrypted. Also missing is a way to set key/cert files and cipher suite per domain. (I aksed spice folks to avoid this problem by using

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-19 Thread Daniel P. Berrange
On Mon, Oct 19, 2009 at 05:47:47PM +0200, Dan Kenigsberg wrote: Thanks for the patches (and sorry for the late response). The patches are fine, though I am still missing a means to control which of spice channels are to be encrypted. Also missing is a way to set key/cert files and cipher

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-19 Thread Dan Kenigsberg
On Mon, Oct 19, 2009 at 04:52:10PM +0100, Daniel P. Berrange wrote: On Mon, Oct 19, 2009 at 05:47:47PM +0200, Dan Kenigsberg wrote: Thanks for the patches (and sorry for the late response). The patches are fine, though I am still missing a means to control which of spice channels are to

Re: [libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-10-19 Thread Daniel P. Berrange
On Mon, Oct 19, 2009 at 06:10:08PM +0200, Dan Kenigsberg wrote: On Mon, Oct 19, 2009 at 04:52:10PM +0100, Daniel P. Berrange wrote: On Mon, Oct 19, 2009 at 05:47:47PM +0200, Dan Kenigsberg wrote: Thanks for the patches (and sorry for the late response). The patches are fine, though I

[libvirt] [PATCH 2/4] Add a graphics type for SPICE protocol

2009-09-29 Thread Daniel P. Berrange
This adds an element graphics type='spice' port='5903' tlsPort='5904' listen='127.0.0.1'/ This is the bare minimum that should be exposed in the guest config for SPICE. Other parameters are better handled as per host level configuration tunables * docs/schemas/domain.rng: Define the SPICE