Re: [libvirt] [PATCH 2/4] conf: Move hugepage XML validation check out of qemu_command

2018-07-13 Thread Michal Privoznik
On 07/13/2018 02:02 PM, Pavel Hrdina wrote: > On Wed, Jul 11, 2018 at 06:03:08PM +0200, Pavel Hrdina wrote: >> To make it clear I'll summarize all the possible combinations and how it >> should work so we are on the same page. > > originally: before commit [1] > now: after commit [1] (current

Re: [libvirt] [PATCH 2/4] conf: Move hugepage XML validation check out of qemu_command

2018-07-13 Thread Pavel Hrdina
On Wed, Jul 11, 2018 at 06:03:08PM +0200, Pavel Hrdina wrote: > To make it clear I'll summarize all the possible combinations and how it > should work so we are on the same page. originally: before commit [1] now: after commit [1] (current master) expect: what this patch series should fix

Re: [libvirt] [PATCH 2/4] conf: Move hugepage XML validation check out of qemu_command

2018-07-11 Thread Pavel Hrdina
On Wed, Jul 11, 2018 at 05:47:58PM +0200, Michal Privoznik wrote: > On 07/11/2018 05:25 PM, Pavel Hrdina wrote: > > On Wed, Jul 11, 2018 at 05:05:07PM +0200, Michal Privoznik wrote: > >> On 07/11/2018 10:22 AM, Pavel Hrdina wrote: > >>> We can safely validate the hugepage nodeset attribute at a

Re: [libvirt] [PATCH 2/4] conf: Move hugepage XML validation check out of qemu_command

2018-07-11 Thread Michal Privoznik
On 07/11/2018 05:25 PM, Pavel Hrdina wrote: > On Wed, Jul 11, 2018 at 05:05:07PM +0200, Michal Privoznik wrote: >> On 07/11/2018 10:22 AM, Pavel Hrdina wrote: >>> We can safely validate the hugepage nodeset attribute at a define time. >>> This validation is not done for already existing domains

Re: [libvirt] [PATCH 2/4] conf: Move hugepage XML validation check out of qemu_command

2018-07-11 Thread Pavel Hrdina
On Wed, Jul 11, 2018 at 05:05:07PM +0200, Michal Privoznik wrote: > On 07/11/2018 10:22 AM, Pavel Hrdina wrote: > > We can safely validate the hugepage nodeset attribute at a define time. > > This validation is not done for already existing domains when the daemon > > is restarted. > > > > All

Re: [libvirt] [PATCH 2/4] conf: Move hugepage XML validation check out of qemu_command

2018-07-11 Thread Michal Privoznik
On 07/11/2018 10:22 AM, Pavel Hrdina wrote: > We can safely validate the hugepage nodeset attribute at a define time. > This validation is not done for already existing domains when the daemon > is restarted. > > All the changes to the tests are necessary because we move the error > from domain

[libvirt] [PATCH 2/4] conf: Move hugepage XML validation check out of qemu_command

2018-07-11 Thread Pavel Hrdina
We can safely validate the hugepage nodeset attribute at a define time. This validation is not done for already existing domains when the daemon is restarted. All the changes to the tests are necessary because we move the error from domain start into XML parse. Signed-off-by: Pavel Hrdina ---