Re: [libvirt] [PATCH 2/4] conf: domain: Introduce virDomainDeviceInfoIterate flags

2018-12-12 Thread John Ferlan
On 12/12/18 3:29 AM, Erik Skultety wrote: > On Tue, Dec 11, 2018 at 06:50:19PM -0500, John Ferlan wrote: >> >> >> On 12/7/18 9:47 AM, Erik Skultety wrote: >>> One of the usages of the device iterator is to run config validation. >>> That's a problem for graphics devices, because they don't have

Re: [libvirt] [PATCH 2/4] conf: domain: Introduce virDomainDeviceInfoIterate flags

2018-12-12 Thread Erik Skultety
On Tue, Dec 11, 2018 at 06:50:19PM -0500, John Ferlan wrote: > > > On 12/7/18 9:47 AM, Erik Skultety wrote: > > One of the usages of the device iterator is to run config validation. > > That's a problem for graphics devices, because they don't have any @info > > data (graphics shouldn't have been

Re: [libvirt] [PATCH 2/4] conf: domain: Introduce virDomainDeviceInfoIterate flags

2018-12-11 Thread John Ferlan
On 12/7/18 9:47 AM, Erik Skultety wrote: > One of the usages of the device iterator is to run config validation. > That's a problem for graphics devices, because they don't have any @info > data (graphics shouldn't have been considered as devices in the first > place), and simply passing NULL

[libvirt] [PATCH 2/4] conf: domain: Introduce virDomainDeviceInfoIterate flags

2018-12-07 Thread Erik Skultety
One of the usages of the device iterator is to run config validation. That's a problem for graphics devices, because they don't have any @info data (graphics shouldn't have been considered as devices in the first place), and simply passing NULL would crash a few callbacks invoked from the