Re: [libvirt] [PATCH 2/6] qemu_conf: Drop a pair of needless 'cleanup' labels

2019-09-10 Thread Pavel Hrdina
On Tue, Sep 10, 2019 at 09:19:50AM +0200, Pavel Hrdina wrote: > On Mon, Sep 09, 2019 at 06:00:23PM +0200, Michal Privoznik wrote: > > There are two 'cleanup' labels - one in > > virQEMUDriverConfigHugeTLBFSInit() and the other in > > virQEMUDriverConfigSetDefaults() that do nothing more than > >

Re: [libvirt] [PATCH 2/6] qemu_conf: Drop a pair of needless 'cleanup' labels

2019-09-10 Thread Pavel Hrdina
On Mon, Sep 09, 2019 at 06:00:23PM +0200, Michal Privoznik wrote: > There are two 'cleanup' labels - one in > virQEMUDriverConfigHugeTLBFSInit() and the other in > virQEMUDriverConfigSetDefaults() that do nothing more than > return and integer value. No memory freeing or anything important > is

Re: [libvirt] [PATCH 2/6] qemu_conf: Drop a pair of needless 'cleanup' labels

2019-09-09 Thread Daniel Henrique Barboza
On 9/9/19 1:00 PM, Michal Privoznik wrote: There are two 'cleanup' labels - one in virQEMUDriverConfigHugeTLBFSInit() and the other in virQEMUDriverConfigSetDefaults() that do nothing more than return and integer value. No memory freeing or anything important is done there. Drop them in

[libvirt] [PATCH 2/6] qemu_conf: Drop a pair of needless 'cleanup' labels

2019-09-09 Thread Michal Privoznik
There are two 'cleanup' labels - one in virQEMUDriverConfigHugeTLBFSInit() and the other in virQEMUDriverConfigSetDefaults() that do nothing more than return and integer value. No memory freeing or anything important is done there. Drop them in favour of returning immediately. Signed-off-by: