Re: [libvirt] [PATCH 3/3] Add qemu help string parsing tests

2009-06-11 Thread Mark McLoughlin
On Thu, 2009-06-11 at 14:14 +0100, Daniel P. Berrange wrote: .. The test program is only built if WITH_QEMU is defined, so ... ... this source file conditional is redundant. ... And can kill this dummy main() too I didn't dream this up myself, you know ... take a look at qemuxml2argvtest

Re: [libvirt] [PATCH 3/3] Add qemu help string parsing tests

2009-06-11 Thread Daniel P. Berrange
On Thu, Jun 11, 2009 at 02:23:27PM +0100, Mark McLoughlin wrote: On Thu, 2009-06-11 at 14:14 +0100, Daniel P. Berrange wrote: .. The test program is only built if WITH_QEMU is defined, so ... ... this source file conditional is redundant. ... And can kill this dummy main() too I

Re: [libvirt] [PATCH 3/3] Add qemu help string parsing tests

2009-06-11 Thread Daniel Veillard
On Wed, Jun 10, 2009 at 09:02:41PM +0100, Mark McLoughlin wrote: Signed-off-by: Mark McLoughlin mar...@redhat.com --- src/qemu_conf.c| 10 +- src/qemu_conf.h|6 ++ tests/Makefile.am |9 ++- tests/qemuhelpdata/kvm-74