Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

On Thu, Apr 27, 2017 at 04:13:43PM +0200, Andrea Bolognani wrote: > On Thu, 2017-04-27 at 10:24 +0200, Pavel Hrdina wrote: > > > You're technically correct[1]. However, piix3-uhci is > > > another piece of Intel-derived hardware so in practice > > > qemu-system-aarch64 is very unlikely to have it

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

On Thu, 2017-04-27 at 10:24 +0200, Pavel Hrdina wrote: > > You're technically correct[1]. However, piix3-uhci is > > another piece of Intel-derived hardware so in practice > > qemu-system-aarch64 is very unlikely to have it compiled > > in and most users will end up getting the error instead. >  >

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

On Thu, Apr 27, 2017 at 11:14:42AM +1000, David Gibson wrote: > On Wed, 26 Apr 2017 18:20:24 +0200 > Andrea Bolognani wrote: > > > [*actually* added David and Drew to CC smh] > > > > On Wed, 2017-04-26 at 18:13 +0200, Andrea Bolognani wrote: > > > The rest looks good, but

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

On Thu, Apr 27, 2017 at 09:42:24AM +0200, Andrea Bolognani wrote: > On Wed, 2017-04-26 at 18:59 +0200, Pavel Hrdina wrote: > > > If qemu-xhci is not available but usb-nec-xhci is, it would > > > probably be nicer to pick the latter rather than leaving it > > > unspecified (which will result in an

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

On Wed, 2017-04-26 at 18:59 +0200, Pavel Hrdina wrote: > > If qemu-xhci is not available but usb-nec-xhci is, it would > > probably be nicer to pick the latter rather than leaving it > > unspecified (which will result in an error later on). >  > This is not true, if the qemu-xhci is not available

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

On Wed, 26 Apr 2017 18:20:24 +0200 Andrea Bolognani wrote: > [*actually* added David and Drew to CC smh] > > On Wed, 2017-04-26 at 18:13 +0200, Andrea Bolognani wrote: > > The rest looks good, but I'd like to make sure changing the > > default is something that's okay with

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

On Wed, Apr 26, 2017 at 06:13:44PM +0200, Andrea Bolognani wrote: > [David and Drew added to CC, feel free to skip to the bottom] > > On Thu, 2017-04-20 at 15:44 +0200, Pavel Hrdina wrote: > [...] > > +} else if (def->os.arch == VIR_ARCH_AARCH64 && > > +   

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

[*actually* added David and Drew to CC smh] On Wed, 2017-04-26 at 18:13 +0200, Andrea Bolognani wrote: > The rest looks good, but I'd like to make sure changing the > default is something that's okay with everyone. > > David, Drew, do you have anything against changing the > default USB

Re: [libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

[David and Drew added to CC, feel free to skip to the bottom] On Thu, 2017-04-20 at 15:44 +0200, Pavel Hrdina wrote: [...] > +} else if (def->os.arch == VIR_ARCH_AARCH64 && > +   virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_QEMU_XHCI)) > { > +/* If

[libvirt] [PATCH 3/3] qemu: use qemu-xhci USB controller by default for ppc64 and aarch64

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1438682 Signed-off-by: Pavel Hrdina --- src/qemu/qemu_domain.c | 13 +-- ...uxml2argv-aarch64-usb-controller-qemu-xhci.args | 20