Re: [libvirt] [PATCH 3/4] Validate the bios_date format for sysinfo

2013-05-09 Thread Martin Kletzander
On 04/30/2013 08:19 PM, John Ferlan wrote: --- src/conf/domain_conf.c | 24 1 file changed, 24 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a8b5dfd..43273f8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@

Re: [libvirt] [PATCH 3/4] Validate the bios_date format for sysinfo

2013-05-09 Thread John Ferlan
On 05/09/2013 06:59 AM, Martin Kletzander wrote: On 04/30/2013 08:19 PM, John Ferlan wrote: --- src/conf/domain_conf.c | 24 1 file changed, 24 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a8b5dfd..43273f8 100644 ---

Re: [libvirt] [PATCH 3/4] Validate the bios_date format for sysinfo

2013-05-09 Thread Martin Kletzander
On 05/09/2013 01:43 PM, John Ferlan wrote: On 05/09/2013 06:59 AM, Martin Kletzander wrote: On 04/30/2013 08:19 PM, John Ferlan wrote: --- src/conf/domain_conf.c | 24 1 file changed, 24 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c

Re: [libvirt] [PATCH 3/4] Validate the bios_date format for sysinfo

2013-05-09 Thread John Ferlan
On 05/09/2013 09:58 AM, Martin Kletzander wrote: On 05/09/2013 01:43 PM, John Ferlan wrote: On 05/09/2013 06:59 AM, Martin Kletzander wrote: On 04/30/2013 08:19 PM, John Ferlan wrote: --- src/conf/domain_conf.c | 24 1 file changed, 24 insertions(+) diff --git

Re: [libvirt] [PATCH 3/4] Validate the bios_date format for sysinfo

2013-05-09 Thread Eric Blake
On 05/09/2013 05:43 AM, John Ferlan wrote: On 05/09/2013 06:59 AM, Martin Kletzander wrote: On 04/30/2013 08:19 PM, John Ferlan wrote: I find it a bit harder to read. Wouldn't this be more nicer if we used sscanf()? Or we could take care a bit about the date and do it even shorter with

[libvirt] [PATCH 3/4] Validate the bios_date format for sysinfo

2013-04-30 Thread John Ferlan
--- src/conf/domain_conf.c | 24 1 file changed, 24 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a8b5dfd..43273f8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -11591,6 +11591,30 @@ virDomainDefParseXML(xmlDocPtr