Re: [libvirt] [PATCH 3/4] qemu: Don't remove hash entry of other domains

2013-02-11 Thread Daniel P. Berrange
On Fri, Feb 08, 2013 at 09:08:01PM +0800, Osier Yang wrote: qemuProcessStart invokes qemuProcessStop when fails, to avoid removing hash entry which belongs to other domain(s), this introduces a new virBitmapPtr argument for qemuProcessStop. And qemuProcessStart sets the bit for the disk only

Re: [libvirt] [PATCH 3/4] qemu: Don't remove hash entry of other domains

2013-02-11 Thread Osier Yang
On 2013年02月09日 05:09, John Ferlan wrote: On 02/08/2013 08:08 AM, Osier Yang wrote: qemuProcessStart invokes qemuProcessStop when fails, to avoid removing hash entry which belongs to other domain(s), this introduces a new virBitmapPtr argument for qemuProcessStop. And qemuProcessStart sets the

Re: [libvirt] [PATCH 3/4] qemu: Don't remove hash entry of other domains

2013-02-11 Thread Osier Yang
On 2013年02月11日 18:59, Daniel P. Berrange wrote: On Fri, Feb 08, 2013 at 09:08:01PM +0800, Osier Yang wrote: qemuProcessStart invokes qemuProcessStop when fails, to avoid removing hash entry which belongs to other domain(s), this introduces a new virBitmapPtr argument for qemuProcessStop. And

Re: [libvirt] [PATCH 3/4] qemu: Don't remove hash entry of other domains

2013-02-11 Thread Daniel P. Berrange
On Mon, Feb 11, 2013 at 07:37:14PM +0800, Osier Yang wrote: On 2013年02月11日 18:59, Daniel P. Berrange wrote: On Fri, Feb 08, 2013 at 09:08:01PM +0800, Osier Yang wrote: qemuProcessStart invokes qemuProcessStop when fails, to avoid removing hash entry which belongs to other domain(s), this

Re: [libvirt] [PATCH 3/4] qemu: Don't remove hash entry of other domains

2013-02-11 Thread Osier Yang
On 2013年02月12日 01:44, Daniel P. Berrange wrote: On Mon, Feb 11, 2013 at 07:37:14PM +0800, Osier Yang wrote: On 2013年02月11日 18:59, Daniel P. Berrange wrote: On Fri, Feb 08, 2013 at 09:08:01PM +0800, Osier Yang wrote: qemuProcessStart invokes qemuProcessStop when fails, to avoid removing hash

[libvirt] [PATCH 3/4] qemu: Don't remove hash entry of other domains

2013-02-08 Thread Osier Yang
qemuProcessStart invokes qemuProcessStop when fails, to avoid removing hash entry which belongs to other domain(s), this introduces a new virBitmapPtr argument for qemuProcessStop. And qemuProcessStart sets the bit for the disk only if it's successfully added into the hash table. Thus if the

Re: [libvirt] [PATCH 3/4] qemu: Don't remove hash entry of other domains

2013-02-08 Thread John Ferlan
On 02/08/2013 08:08 AM, Osier Yang wrote: qemuProcessStart invokes qemuProcessStop when fails, to avoid removing hash entry which belongs to other domain(s), this introduces a new virBitmapPtr argument for qemuProcessStop. And qemuProcessStart sets the bit for the disk only if it's