Re: [libvirt] [PATCH 3/6] storage: fs: Don't attempt directory creation if it already exists

2015-07-16 Thread tzheng
Hi,Cole After this patch is included in libvirt on rhel7.2,virt-manager can not create dir pool with existing directory. There is no default pool created in a fresh rhel7.2 system,so if I try to create default pool,the below error shows: Error creating pool: Could not build storage pool:

Re: [libvirt] [PATCH 3/6] storage: fs: Don't attempt directory creation if it already exists

2015-07-16 Thread Christophe Fergeau
On Thu, Jul 16, 2015 at 02:02:39PM +0800, tzheng wrote: Hi,Cole After this patch is included in libvirt on rhel7.2,virt-manager can not create dir pool with existing directory. There is no default pool created in a fresh rhel7.2 system,so if I try to create default pool,the below error

Re: [libvirt] [PATCH 3/6] storage: fs: Don't attempt directory creation if it already exists

2015-07-16 Thread tzheng
On 07/16/2015 07:39 PM, Christophe Fergeau wrote: On Thu, Jul 16, 2015 at 02:02:39PM +0800, tzheng wrote: Hi,Cole After this patch is included in libvirt on rhel7.2,virt-manager can not create dir pool with existing directory. There is no default pool created in a fresh rhel7.2 system,so if I

Re: [libvirt] [PATCH 3/6] storage: fs: Don't attempt directory creation if it already exists

2015-04-28 Thread Peter Krempa
On Mon, Apr 27, 2015 at 16:48:41 -0400, Cole Robinson wrote: The current code attempts to handle this, but it only catches mkdir failing with EEXIST. However if say trying to build /tmp for an unprivileged qemu:///session, mkdir will fail with EPERM. Rather than catch any errors, just don't

Re: [libvirt] [PATCH 3/6] storage: fs: Don't attempt directory creation if it already exists

2015-04-28 Thread Cole Robinson
On 04/28/2015 08:19 AM, Peter Krempa wrote: On Mon, Apr 27, 2015 at 16:48:41 -0400, Cole Robinson wrote: The current code attempts to handle this, but it only catches mkdir failing with EEXIST. However if say trying to build /tmp for an unprivileged qemu:///session, mkdir will fail with EPERM.

[libvirt] [PATCH 3/6] storage: fs: Don't attempt directory creation if it already exists

2015-04-27 Thread Cole Robinson
The current code attempts to handle this, but it only catches mkdir failing with EEXIST. However if say trying to build /tmp for an unprivileged qemu:///session, mkdir will fail with EPERM. Rather than catch any errors, just don't attempt mkdir if the directory already exists. ---