Re: [libvirt] [PATCH 3/7] Move dtrace probe macros into separate header file

2014-03-10 Thread Daniel P. Berrange
On Wed, Mar 05, 2014 at 09:18:54AM -0500, John Ferlan wrote: On 03/03/2014 02:18 PM, Daniel P. Berrange wrote: The dtrace probe macros rely on the logging API. We can't make the internal.h header include the virlog.h header though since that'd be a circular include. Instead simply split

Re: [libvirt] [PATCH 3/7] Move dtrace probe macros into separate header file

2014-03-05 Thread John Ferlan
On 03/03/2014 02:18 PM, Daniel P. Berrange wrote: The dtrace probe macros rely on the logging API. We can't make the internal.h header include the virlog.h header though since that'd be a circular include. Instead simply split the dtrace probes into their own header file, since there's no

Re: [libvirt] [PATCH 3/7] Move dtrace probe macros into separate header file

2014-03-04 Thread Eric Blake
On 03/03/2014 12:18 PM, Daniel P. Berrange wrote: The dtrace probe macros rely on the logging API. We can't make the internal.h header include the virlog.h header though since that'd be a circular include. Instead simply split the dtrace probes into their own header file, since there's no

[libvirt] [PATCH 3/7] Move dtrace probe macros into separate header file

2014-03-03 Thread Daniel P. Berrange
The dtrace probe macros rely on the logging API. We can't make the internal.h header include the virlog.h header though since that'd be a circular include. Instead simply split the dtrace probes into their own header file, since there's no compelling reason for them to be in the main internal.h