Re: [libvirt] [PATCH 4/4] conf: domain: gfx: Iterate over graphics devices when doing validation

2018-12-12 Thread Erik Skultety
On Tue, Dec 11, 2018 at 06:54:31PM -0500, John Ferlan wrote: > > > On 12/7/18 9:47 AM, Erik Skultety wrote: > > The validation code for graphics has been in place for a while, but > > because it is only executed from the device iterator, that validation > > code was never truly run. The

Re: [libvirt] [PATCH 4/4] conf: domain: gfx: Iterate over graphics devices when doing validation

2018-12-12 Thread Erik Skultety
On Tue, Dec 11, 2018 at 06:54:31PM -0500, John Ferlan wrote: > > > On 12/7/18 9:47 AM, Erik Skultety wrote: > > The validation code for graphics has been in place for a while, but > > because it is only executed from the device iterator, that validation > > code was never truly run. The

Re: [libvirt] [PATCH 4/4] conf: domain: gfx: Iterate over graphics devices when doing validation

2018-12-11 Thread John Ferlan
On 12/7/18 9:47 AM, Erik Skultety wrote: > The validation code for graphics has been in place for a while, but > because it is only executed from the device iterator, that validation > code was never truly run. The unfortunate side effect of this whole mess dang confusing postparse and

[libvirt] [PATCH 4/4] conf: domain: gfx: Iterate over graphics devices when doing validation

2018-12-07 Thread Erik Skultety
The validation code for graphics has been in place for a while, but because it is only executed from the device iterator, that validation code was never truly run. The unfortunate side effect of this whole mess was that a few capabilities were missing from the test suite, which in turn meant that