Re: [libvirt] [PATCH 4/4] qemu: caps: Format SEV platform data into qemuCaps cache

2018-08-16 Thread Erik Skultety
On Wed, Aug 15, 2018 at 06:23:28PM +0200, Peter Krempa wrote: > On Wed, Aug 15, 2018 at 17:02:08 +0200, Erik Skultety wrote: > > Since we're not saving the platform-specific data into a cache, we're > > not going to populate the structure, which in turn will cause a crash > > upon calling

Re: [libvirt] [PATCH 4/4] qemu: caps: Format SEV platform data into qemuCaps cache

2018-08-15 Thread Peter Krempa
On Wed, Aug 15, 2018 at 17:02:08 +0200, Erik Skultety wrote: > Since we're not saving the platform-specific data into a cache, we're > not going to populate the structure, which in turn will cause a crash > upon calling virNodeGetSEVInfo because of a NULL pointer dereference. > Ultimately, we

Re: [libvirt] [PATCH 4/4] qemu: caps: Format SEV platform data into qemuCaps cache

2018-08-15 Thread Erik Skultety
On Wed, Aug 15, 2018 at 05:02:08PM +0200, Erik Skultety wrote: > Since we're not saving the platform-specific data into a cache, we're > not going to populate the structure, which in turn will cause a crash > upon calling virNodeGetSEVInfo because of a NULL pointer dereference. > Ultimately, we

[libvirt] [PATCH 4/4] qemu: caps: Format SEV platform data into qemuCaps cache

2018-08-15 Thread Erik Skultety
Since we're not saving the platform-specific data into a cache, we're not going to populate the structure, which in turn will cause a crash upon calling virNodeGetSEVInfo because of a NULL pointer dereference. Ultimately, we should start caching this data along with host-specific capabilities like