Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Eduardo Habkost
On Wed, Jan 16, 2019 at 05:24:02PM +0100, Andrea Bolognani wrote: > On Wed, 2019-01-16 at 15:40 +, Daniel P. Berrangé wrote: > > On Wed, Jan 16, 2019 at 12:45:43PM -0200, Eduardo Habkost wrote: > > > But I don't want to create unnecessary obstacles for libvirt, so > > > if there's a real

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Andrea Bolognani
On Wed, 2019-01-16 at 15:40 +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 12:45:43PM -0200, Eduardo Habkost wrote: > > But I don't want to create unnecessary obstacles for libvirt, so > > if there's a real benefit in promising compatibility between both > > device types, we can still

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 12:45:43PM -0200, Eduardo Habkost wrote: > On Wed, Jan 16, 2019 at 02:37:22PM +, Daniel P. Berrangé wrote: > > On Wed, Jan 16, 2019 at 03:31:49PM +0100, Andrea Bolognani wrote: > > > On Wed, 2019-01-16 at 12:44 +, Daniel P. Berrangé wrote: > > > > On Wed, Jan 16,

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Eduardo Habkost
On Wed, Jan 16, 2019 at 02:37:22PM +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 03:31:49PM +0100, Andrea Bolognani wrote: > > On Wed, 2019-01-16 at 12:44 +, Daniel P. Berrangé wrote: > > > On Wed, Jan 16, 2019 at 01:29:13PM +0100, Andrea Bolognani wrote: > > > > On Wed,

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 03:31:49PM +0100, Andrea Bolognani wrote: > On Wed, 2019-01-16 at 12:44 +, Daniel P. Berrangé wrote: > > On Wed, Jan 16, 2019 at 01:29:13PM +0100, Andrea Bolognani wrote: > > > On Wed, 2019-01-16 at 11:39 +, Daniel P. Berrangé wrote: > > > > In the > > > > future

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Andrea Bolognani
On Wed, 2019-01-16 at 12:44 +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 01:29:13PM +0100, Andrea Bolognani wrote: > > On Wed, 2019-01-16 at 11:39 +, Daniel P. Berrangé wrote: > > > In the > > > future they may add properties to, or change the defaults on, the > > > -transitional

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 01:29:13PM +0100, Andrea Bolognani wrote: > On Wed, 2019-01-16 at 11:39 +, Daniel P. Berrangé wrote: > > On Wed, Jan 16, 2019 at 12:31:04PM +0100, Andrea Bolognani wrote: > > > On Tue, 2019-01-15 at 16:56 +, Daniel P. Berrangé wrote: > > > > A transitional device is

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Andrea Bolognani
On Wed, 2019-01-16 at 11:39 +, Daniel P. Berrangé wrote: > On Wed, Jan 16, 2019 at 12:31:04PM +0100, Andrea Bolognani wrote: > > On Tue, 2019-01-15 at 16:56 +, Daniel P. Berrangé wrote: > > > A transitional device is 100% identical to the existing device > > > types, so we can simply not

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Daniel P . Berrangé
On Wed, Jan 16, 2019 at 12:31:04PM +0100, Andrea Bolognani wrote: > On Tue, 2019-01-15 at 16:56 +, Daniel P. Berrangé wrote: > > On Sun, Jan 13, 2019 at 06:12:06PM -0500, Cole Robinson wrote: > > > Add new model values for virtio transitional devices. When > > > combined with bus='virtio': >

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-16 Thread Andrea Bolognani
On Tue, 2019-01-15 at 16:56 +, Daniel P. Berrangé wrote: > On Sun, Jan 13, 2019 at 06:12:06PM -0500, Cole Robinson wrote: > > Add new model values for virtio transitional devices. When > > combined with bus='virtio': > > > > * "virtio-transitional" maps to qemu "virtio-blk-pci-transitional"

Re: [libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-15 Thread Daniel P . Berrangé
On Sun, Jan 13, 2019 at 06:12:06PM -0500, Cole Robinson wrote: > Add new model values for virtio transitional devices. When > combined with bus='virtio': > > * "virtio-transitional" maps to qemu "virtio-blk-pci-transitional" > * "virtio-non-transitional" maps to qemu

[libvirt] [PATCH 4/6] qemu: Wire up disk model=virtio-{non-}transitional

2019-01-13 Thread Cole Robinson
Add new model values for virtio transitional devices. When combined with bus='virtio': * "virtio-transitional" maps to qemu "virtio-blk-pci-transitional" * "virtio-non-transitional" maps to qemu "virtio-blk-pci-non-transitional" Signed-off-by: Cole Robinson --- src/qemu/qemu_command.c