Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema

2023-01-12 Thread Jiri Denemark
On Thu, Jan 12, 2023 at 09:45:39 -0500, Laine Stump wrote: > On 1/11/23 1:33 PM, Daniel P. Berrangé wrote: > > On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote: > >> + >> upstream='eth42'/> > > > > I don't think that 'upstream' is really describing a property of the > > backend.

Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema

2023-01-12 Thread Stefano Brivio
On Thu, 12 Jan 2023 09:45:39 -0500 Laine Stump wrote: > On 1/11/23 1:33 PM, Daniel P. Berrangé wrote: > > On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote: > >> Initial support for network devices using passt (https://passt.top) > >> for the backend connection will require: > >> >

Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema

2023-01-12 Thread Laine Stump
On 1/11/23 1:33 PM, Daniel P. Berrangé wrote: On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote: Initial support for network devices using passt (https://passt.top) for the backend connection will require: * new attributes of the subelement: * "type" that can have the value

Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema

2023-01-11 Thread Daniel P . Berrangé
On Sun, Jan 08, 2023 at 11:11:07PM -0500, Laine Stump wrote: > Initial support for network devices using passt (https://passt.top) > for the backend connection will require: > > * new attributes of the subelement: > * "type" that can have the value "passt" (to differentiate from > slirp,

Re: [libvirt PATCH 4/9] conf: add passt XML additions to schema

2023-01-08 Thread Ján Tomko
On a Sunday in 2023, Laine Stump wrote: Initial support for network devices using passt (https://passt.top) for the backend connection will require: * new attributes of the subelement: * "type" that can have the value "passt" (to differentiate from slirp, because both slirp and passt will

[libvirt PATCH 4/9] conf: add passt XML additions to schema

2023-01-08 Thread Laine Stump
Initial support for network devices using passt (https://passt.top) for the backend connection will require: * new attributes of the subelement: * "type" that can have the value "passt" (to differentiate from slirp, because both slirp and passt will use ) * "logFile" (a path to a file

Re: [libvirt] [PATCH 4/9] conf: add private data to virDomainFSDef

2020-01-07 Thread Daniel P . Berrangé
On Mon, Jan 06, 2020 at 03:26:00PM +0100, Ján Tomko wrote: > Add an object to hold the private data and call the > allocation function if it's present in xmlopt. > > Signed-off-by: Ján Tomko > --- > src/conf/domain_conf.c | 7 ++- > src/conf/domain_conf.h | 2 ++ > 2 files changed, 8

[libvirt] [PATCH 4/9] conf: add private data to virDomainFSDef

2020-01-06 Thread Ján Tomko
Add an object to hold the private data and call the allocation function if it's present in xmlopt. Signed-off-by: Ján Tomko --- src/conf/domain_conf.c | 7 ++- src/conf/domain_conf.h | 2 ++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH 4/9] conf: add to

2017-03-28 Thread John Ferlan
On 03/23/2017 11:26 AM, Ján Tomko wrote: > Add a new attribute to control interrupt remapping. > > https://bugzilla.redhat.com/show_bug.cgi?id=1427005 > --- > docs/formatdomain.html.in | 22 - > docs/schemas/domaincommon.rng | 9 +

[libvirt] [PATCH 4/9] conf: add to

2017-03-23 Thread Ján Tomko
Add a new attribute to control interrupt remapping. https://bugzilla.redhat.com/show_bug.cgi?id=1427005 --- docs/formatdomain.html.in | 22 - docs/schemas/domaincommon.rng | 9 + src/conf/domain_conf.c |

Re: [libvirt] [PATCH 4/9] conf: add virDomainHasNet

2015-03-13 Thread Jim Fehlig
Marek Marczykowski-Górecki wrote: virDomainNetFindIdx no longer returns info whether device was not found, or there was multiple matches. Additionally it already handle error reporting. Introduce virDomainHasNet which does a simple task, without implicit error reporting. Signed-off-by: Marek

[libvirt] [PATCH 4/9] conf: add virDomainHasNet

2015-03-06 Thread Marek Marczykowski-Górecki
virDomainNetFindIdx no longer returns info whether device was not found, or there was multiple matches. Additionally it already handle error reporting. Introduce virDomainHasNet which does a simple task, without implicit error reporting. Signed-off-by: Marek Marczykowski-Górecki