Re: [libvirt] [PATCH 5/4] security: Don't try to lock NULL paths

2018-09-25 Thread John Ferlan
On 9/25/18 3:34 AM, Michal Privoznik wrote: > It may happen that in the list of paths/disk sources to relabel > there is a disk source. If that is the case, the path is NULL. In > that case, we shouldn't try to lock the path. It's likely a > network disk anyway and therefore there is nothing to

Re: [libvirt] [PATCH 5/4] security: Don't try to lock NULL paths

2018-09-25 Thread Erik Skultety
On Tue, Sep 25, 2018 at 01:01:59PM +0200, Michal Privoznik wrote: > On 09/25/2018 12:47 PM, Erik Skultety wrote: > > On Tue, Sep 25, 2018 at 09:34:50AM +0200, Michal Privoznik wrote: > >> It may happen that in the list of paths/disk sources to relabel > >> there is a disk source. If that is the

Re: [libvirt] [PATCH 5/4] security: Don't try to lock NULL paths

2018-09-25 Thread Michal Privoznik
On 09/25/2018 12:47 PM, Erik Skultety wrote: > On Tue, Sep 25, 2018 at 09:34:50AM +0200, Michal Privoznik wrote: >> It may happen that in the list of paths/disk sources to relabel >> there is a disk source. If that is the case, the path is NULL. In > > Is there a way to prevent to such a source

Re: [libvirt] [PATCH 5/4] security: Don't try to lock NULL paths

2018-09-25 Thread Erik Skultety
On Tue, Sep 25, 2018 at 09:34:50AM +0200, Michal Privoznik wrote: > It may happen that in the list of paths/disk sources to relabel > there is a disk source. If that is the case, the path is NULL. In Is there a way to prevent to such a source would not make it into the list in the first place? >

[libvirt] [PATCH 5/4] security: Don't try to lock NULL paths

2018-09-25 Thread Michal Privoznik
It may happen that in the list of paths/disk sources to relabel there is a disk source. If that is the case, the path is NULL. In that case, we shouldn't try to lock the path. It's likely a network disk anyway and therefore there is nothing to lock. Signed-off-by: Michal Privoznik ---