Re: [libvirt] [PATCH 5/5] qemu/rbd: improve rbd device specification

2011-10-12 Thread Daniel P. Berrange
On Mon, Sep 19, 2011 at 09:13:43PM -0700, Sage Weil wrote: This improves the support for qemu rbd devices by adding support for a few key features (e.g., authentication) and cleaning up the way in which rbd configuration options are passed to qemu. And auth member of the disk source xml

[libvirt] [PATCH 5/5] qemu/rbd: improve rbd device specification

2011-09-19 Thread Sage Weil
This improves the support for qemu rbd devices by adding support for a few key features (e.g., authentication) and cleaning up the way in which rbd configuration options are passed to qemu. And auth member of the disk source xml specifies how librbd should authenticate. The id property is the

Re: [libvirt] [PATCH 5/5] qemu/rbd: improve rbd device specification

2011-09-16 Thread Sage Weil
On Fri, 16 Sep 2011, Tommi Virtanen wrote: On Thu, Sep 15, 2011 at 13:52, Sage Weil s...@newdream.net wrote: +static int buildRBDString(virConnectPtr conn, ... +        /* look up secret */ +        snprintf(idDomain, sizeof(idDomain), %s/%s, disk-authId, +                

Re: [libvirt] [PATCH 5/5] qemu/rbd: improve rbd device specification

2011-09-16 Thread Tommi Virtanen
On Fri, Sep 16, 2011 at 10:01, Sage Weil s...@newdream.net wrote: If I'm reading this right, that puts the ceph secret on the kvm command line. That's not good, that makes it visible to anyone on the host. Yeah, we definitely want something better, but I wanted to make sure the overall

Re: [libvirt] [PATCH 5/5] qemu/rbd: improve rbd device specification

2011-09-16 Thread Tommi Virtanen
On Thu, Sep 15, 2011 at 13:52, Sage Weil s...@newdream.net wrote: +static int buildRBDString(virConnectPtr conn, ... +        /* look up secret */ +        snprintf(idDomain, sizeof(idDomain), %s/%s, disk-authId, +                 disk-authDomain); +        sec = virSecretLookupByUsage(conn,

[libvirt] [PATCH 5/5] qemu/rbd: improve rbd device specification

2011-09-15 Thread Sage Weil
This improves the support for qemu rbd devices by adding support for a few key features (e.g., authentication) and cleaning up the way in which rbd configuration options are passed to qemu. And auth member of the disk source xml specifies how librbd should authenticate. The id property is the