Re: [libvirt] [PATCH 5/5] qemu: caps: Use CAP_DAC_OVERRIDE for probing to avoid permission issues

2019-02-01 Thread Daniel P . Berrangé
On Fri, Feb 01, 2019 at 12:33:19PM +0100, Erik Skultety wrote: > On Fri, Feb 01, 2019 at 10:31:52AM +, Daniel P. Berrangé wrote: > > On Thu, Jan 31, 2019 at 04:26:18PM +0100, Erik Skultety wrote: > > > This is mainly about /dev/sev and its default permissions 0600. Of > > > course, rule of

Re: [libvirt] [PATCH 5/5] qemu: caps: Use CAP_DAC_OVERRIDE for probing to avoid permission issues

2019-02-01 Thread Erik Skultety
On Fri, Feb 01, 2019 at 10:31:52AM +, Daniel P. Berrangé wrote: > On Thu, Jan 31, 2019 at 04:26:18PM +0100, Erik Skultety wrote: > > This is mainly about /dev/sev and its default permissions 0600. Of > > course, rule of 'tinfoil' would be that we can't trust anything, but the > > probing code

Re: [libvirt] [PATCH 5/5] qemu: caps: Use CAP_DAC_OVERRIDE for probing to avoid permission issues

2019-02-01 Thread Daniel P . Berrangé
On Thu, Jan 31, 2019 at 04:26:18PM +0100, Erik Skultety wrote: > This is mainly about /dev/sev and its default permissions 0600. Of > course, rule of 'tinfoil' would be that we can't trust anything, but the > probing code in QEMU is considered safe from security's perspective + we > can't create

[libvirt] [PATCH 5/5] qemu: caps: Use CAP_DAC_OVERRIDE for probing to avoid permission issues

2019-01-31 Thread Erik Skultety
This is mainly about /dev/sev and its default permissions 0600. Of course, rule of 'tinfoil' would be that we can't trust anything, but the probing code in QEMU is considered safe from security's perspective + we can't create an udev rule for this at the moment, because ioctls and filesystem