Re: [libvirt] [PATCH 5/6] qemu: command: Don't format -device isa-fdc, ... twice with two floppy drives

2018-08-09 Thread Ján Tomko
On Thu, Aug 09, 2018 at 02:48:58PM +0200, Peter Krempa wrote: Fix regression introduced in 42fd5a58adb. With q35 machine type which Please wrap the commit id in <> or rephrase the sentence to have the commit id separated by spaces. requires the explicitly specified FDC we'd format two

[libvirt] [PATCH 5/6] qemu: command: Don't format -device isa-fdc, ... twice with two floppy drives

2018-08-09 Thread Peter Krempa
Fix regression introduced in 42fd5a58adb. With q35 machine type which requires the explicitly specified FDC we'd format two isa-fdc controllers to the command line as the code was moved to a place where it's called per-disk. Move the call back after formatting all disks and reiterate the disks