Re: [libvirt] [PATCH 5/6] storage: conf: Don't set any default mode in the XML

2015-04-28 Thread Cole Robinson
On 04/28/2015 09:23 AM, Peter Krempa wrote: On Mon, Apr 27, 2015 at 16:48:43 -0400, Cole Robinson wrote: The XML parser sets a default mode if none is explicitly passed in. This is then used at pool/vol creation time, and unconditionally reported in the XML. The problem with this approach is

Re: [libvirt] [PATCH 5/6] storage: conf: Don't set any default mode in the XML

2015-04-28 Thread Peter Krempa
On Mon, Apr 27, 2015 at 16:48:43 -0400, Cole Robinson wrote: The XML parser sets a default mode if none is explicitly passed in. This is then used at pool/vol creation time, and unconditionally reported in the XML. The problem with this approach is that it's impossible for other code to

[libvirt] [PATCH 5/6] storage: conf: Don't set any default mode in the XML

2015-04-27 Thread Cole Robinson
The XML parser sets a default mode if none is explicitly passed in. This is then used at pool/vol creation time, and unconditionally reported in the XML. The problem with this approach is that it's impossible for other code to determine if the user explicitly requested a storage mode. There are