Re: [libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

2016-09-22 Thread Daniel P. Berrange
On Thu, Sep 22, 2016 at 01:09:20PM +0200, Martin Kletzander wrote: > On Wed, Sep 21, 2016 at 04:26:31PM +0100, Daniel P. Berrange wrote: > > On Wed, Sep 21, 2016 at 05:10:09PM +0200, Martin Kletzander wrote: > > > On Wed, Sep 21, 2016 at 04:01:23PM +0100, Daniel P. Berrange wrote: > > > > I'm not

Re: [libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

2016-09-22 Thread Martin Kletzander
On Wed, Sep 21, 2016 at 04:26:31PM +0100, Daniel P. Berrange wrote: On Wed, Sep 21, 2016 at 05:10:09PM +0200, Martin Kletzander wrote: On Wed, Sep 21, 2016 at 04:01:23PM +0100, Daniel P. Berrange wrote: > I'm not a fan of the idea of silently picking a different device > for the guest behind

Re: [libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 05:10:09PM +0200, Martin Kletzander wrote: > On Wed, Sep 21, 2016 at 04:01:23PM +0100, Daniel P. Berrange wrote: > > I'm not a fan of the idea of silently picking a different device > > for the guest behind the applications back. By not exposing the > > different device

Re: [libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

2016-09-21 Thread Martin Kletzander
On Wed, Sep 21, 2016 at 04:01:23PM +0100, Daniel P. Berrange wrote: I'm not a fan of the idea of silently picking a different device for the guest behind the applications back. By not exposing the different device types with a "model" attribute, we miss a way to report to the application which

Re: [libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

2016-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2016 at 03:30:55PM +0200, Martin Kletzander wrote: > QEMU added support for ivshmem-plain and ivshmem-doorbell. Those are > reworked varians of legacy ivshmem that are compatible from the guest > POV, but not from host's POV and have sane specification and handling. > > Details

[libvirt] [PATCH 6/7] qemu: Support newer ivshmem device variants

2016-09-21 Thread Martin Kletzander
QEMU added support for ivshmem-plain and ivshmem-doorbell. Those are reworked varians of legacy ivshmem that are compatible from the guest POV, but not from host's POV and have sane specification and handling. Details about the newer device type can be found in qemu's commit 5400c02b90bb: