Re: [libvirt] [PATCH 8/9] virjson: add support for Jansson

2018-04-03 Thread Daniel P . Berrangé
On Tue, Apr 03, 2018 at 12:45:28PM +0200, Peter Krempa wrote: > On Tue, Apr 03, 2018 at 11:39:20 +0100, Daniel Berrange wrote: > > On Sat, Mar 31, 2018 at 11:13:13AM +0200, Peter Krempa wrote: > > > On Thu, Mar 29, 2018 at 01:09:57 +0200, Ján Tomko wrote: > > > > Check for the presence of Jansson l

Re: [libvirt] [PATCH 8/9] virjson: add support for Jansson

2018-04-03 Thread Peter Krempa
On Tue, Apr 03, 2018 at 11:39:20 +0100, Daniel Berrange wrote: > On Sat, Mar 31, 2018 at 11:13:13AM +0200, Peter Krempa wrote: > > On Thu, Mar 29, 2018 at 01:09:57 +0200, Ján Tomko wrote: > > > Check for the presence of Jansson library and prefer it to yajl > > > if possible. > > > > > > The minim

Re: [libvirt] [PATCH 8/9] virjson: add support for Jansson

2018-04-03 Thread Daniel P . Berrangé
On Sat, Mar 31, 2018 at 11:13:13AM +0200, Peter Krempa wrote: > On Thu, Mar 29, 2018 at 01:09:57 +0200, Ján Tomko wrote: > > Check for the presence of Jansson library and prefer it to yajl > > if possible. > > > > The minimum required version is 2.7. > > > > Internally, virJSONValue still stores

Re: [libvirt] [PATCH 8/9] virjson: add support for Jansson

2018-03-31 Thread Peter Krempa
On Sat, Mar 31, 2018 at 11:13:13 +0200, Peter Krempa wrote: > On Thu, Mar 29, 2018 at 01:09:57 +0200, Ján Tomko wrote: > > Check for the presence of Jansson library and prefer it to yajl > > if possible. > > > > The minimum required version is 2.7. > > > > Internally, virJSONValue still stores nu

Re: [libvirt] [PATCH 8/9] virjson: add support for Jansson

2018-03-31 Thread Peter Krempa
On Thu, Mar 29, 2018 at 01:09:57 +0200, Ján Tomko wrote: > Check for the presence of Jansson library and prefer it to yajl > if possible. > > The minimum required version is 2.7. > > Internally, virJSONValue still stores numbers as strings even > though Jansson uses numeric variables for them. >

[libvirt] [PATCH 8/9] virjson: add support for Jansson

2018-03-28 Thread Ján Tomko
Check for the presence of Jansson library and prefer it to yajl if possible. The minimum required version is 2.7. Internally, virJSONValue still stores numbers as strings even though Jansson uses numeric variables for them. The configure script is particularly hideous, but will hopefully go away