Re: [libvirt] [PATCH LIBVIRT v2] libxl: Support cmdline= in xl config files

2016-01-21 Thread Ian Campbell
On Wed, 2016-01-20 at 11:16 -0700, Jim Fehlig wrote: > Ian Campbell wrote: > > ... and consolidate the cmdline/extra/root parsing to facilitate doing > > so. > > > > The logic is the same as xl's parse_cmdline from the current xen.git > > master > > branch

Re: [libvirt] [PATCH LIBVIRT v2] libxl: Support cmdline= in xl config files

2016-01-21 Thread Jim Fehlig
Ian Campbell wrote: > On Wed, 2016-01-20 at 11:16 -0700, Jim Fehlig wrote: >> Ian Campbell wrote: >>> ... and consolidate the cmdline/extra/root parsing to facilitate doing >>> so. >>> >>> The logic is the same as xl's parse_cmdline from the current xen.git >>> master >>> branch

Re: [libvirt] [PATCH LIBVIRT v2] libxl: Support cmdline= in xl config files

2016-01-20 Thread Jim Fehlig
Ian Campbell wrote: > ... and consolidate the cmdline/extra/root parsing to facilitate doing > so. > > The logic is the same as xl's parse_cmdline from the current xen.git master > branch (e6f0e099d2c17de47fd86e817b1998db903cab61). > > In order to introduce a use of VIR_WARN for logging I had to

[libvirt] [PATCH LIBVIRT v2] libxl: Support cmdline= in xl config files

2016-01-20 Thread Ian Campbell
... and consolidate the cmdline/extra/root parsing to facilitate doing so. The logic is the same as xl's parse_cmdline from the current xen.git master branch (e6f0e099d2c17de47fd86e817b1998db903cab61). In order to introduce a use of VIR_WARN for logging I had to add virerror.h and VIR_LOG_INIT.