Re: [libvirt] [PATCH RFC] virhook: adding virHookCheck() inside virHookCall().

2016-07-13 Thread Julio Faracco
Hi Daniel, 2016-07-12 4:59 GMT-03:00 Daniel P. Berrange : > On Mon, Jul 11, 2016 at 03:22:44PM -0300, Julio Faracco wrote: >> This commit introduces the virHookCheck() before running the command (hook). >> The virHookCheck() before virCommandRun() will avoid errors with

Re: [libvirt] [PATCH RFC] virhook: adding virHookCheck() inside virHookCall().

2016-07-12 Thread Daniel P. Berrange
On Mon, Jul 11, 2016 at 03:22:44PM -0300, Julio Faracco wrote: > This commit introduces the virHookCheck() before running the command (hook). > The virHookCheck() before virCommandRun() will avoid errors with changes > (removal and other permissions changes) in the hook file, while the libvirt >

Re: [libvirt] [PATCH RFC] virhook: adding virHookCheck() inside virHookCall().

2016-07-11 Thread Julio Faracco
Hi guys, I sent this patch because we are having some troubles to introduce/remove a new hook. We are creating a package here (RPM, DEB, etc) that configures a VDI and introduces a hook for customization. When the package is removed, the hook is too. After that, all VMs stop to working saying

[libvirt] [PATCH RFC] virhook: adding virHookCheck() inside virHookCall().

2016-07-11 Thread Julio Faracco
This commit introduces the virHookCheck() before running the command (hook). The virHookCheck() before virCommandRun() will avoid errors with changes (removal and other permissions changes) in the hook file, while the libvirt daemon is running. Now, when you remove the hook file while libvirtd is