Re: [libvirt] [PATCH RFC 1/2] Resctrl: Add new xml element to support cache tune

2017-06-22 Thread Eli Qiao
On Thursday, 22 June 2017 at 8:41 PM, Martin Kletzander wrote: > I missed this. Ye, you're right, thanks for showing that with a use > case. We could then require only the cache_id and automatically fill > in level and type. Migration (or rather any start) should then fail if > that cache_id

Re: [libvirt] [PATCH RFC 1/2] Resctrl: Add new xml element to support cache tune

2017-06-22 Thread Martin Kletzander
On Thu, Jun 22, 2017 at 01:24:29PM +0800, Eli Qiao wrote: hi Martin It’s really nice of you to help reviewing the mass code. Thanks. I don’t find a better way to split patch. On Wednesday, 21 June 2017 at 9:53 PM, Martin Kletzander wrote: On Mon, Jun 12, 2017 at 05:48:40PM +0800, Eli Qiao

Re: [libvirt] [PATCH RFC 1/2] Resctrl: Add new xml element to support cache tune

2017-06-21 Thread Eli Qiao
hi Martin It’s really nice of you to help reviewing the mass code. Thanks. I don’t find a better way to split patch. On Wednesday, 21 June 2017 at 9:53 PM, Martin Kletzander wrote: > On Mon, Jun 12, 2017 at 05:48:40PM +0800, Eli Qiao wrote: > > This patch adds new xml element to support

Re: [libvirt] [PATCH RFC 1/2] Resctrl: Add new xml element to support cache tune

2017-06-21 Thread Martin Kletzander
On Mon, Jun 12, 2017 at 05:48:40PM +0800, Eli Qiao wrote: This patch adds new xml element to support cache tune as: ... The cache_id automatically implies level and type. Either have one or the other. I know we talked about this already (maybe multiple times), but without any clear

[libvirt] [PATCH RFC 1/2] Resctrl: Add new xml element to support cache tune

2017-06-12 Thread Eli Qiao
This patch adds new xml element to support cache tune as: ... ... id: any non-minus number cache_id: reference of the host's cache banks id, it's from capabilities level: cache level type: cache bank type size: should be multiples of the min_size of the bank on host. vcpus: cache