Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

2017-06-22 Thread Eli Qiao
On Wednesday, 21 June 2017 at 10:44 PM, Martin Kletzander wrote: > n 21, 2017 at 02:07:15PM +0800, Eli Qiao wrote: > > You don't need to pass the whole structure of all the data. Can't the > qemu function just do something like: > > virResctrlLock() > foreach cachetune: > region =

Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

2017-06-21 Thread Eli Qiao
On Wednesday, 21 June 2017 at 10:44 PM, Martin Kletzander wrote: > You don't need to pass the whole structure of all the data. Can't the > qemu function just do something like: > > virResctrlLock() > foreach cachetune: > region = virResctrlGetFreeRegion(size, type) > foreach cachetune.vcpu: >

Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

2017-06-21 Thread Martin Kletzander
On Wed, Jun 21, 2017 at 02:07:15PM +0800, Eli Qiao wrote: On Tuesday, 20 June 2017 at 8:39 PM, Martin Kletzander wrote: On Mon, Jun 12, 2017 at 05:48:41PM +0800, Eli Qiao wrote: > This patch adds 3 major private interface. > > virResctrlGetFreeCache: return free cache, default cache

Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

2017-06-21 Thread Martin Kletzander
On Tue, Jun 20, 2017 at 03:38:15PM +0800, Eli Qiao wrote: hello, ping BTW this ping sent from gmail is both plaintext and html at the same time. Not only is it treating Makefile.am as domain name, that's not that big of a deal, but because you didn't trim it down, you made 36K patch into 91K

Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

2017-06-21 Thread Eli Qiao
On Tuesday, 20 June 2017 at 8:39 PM, Martin Kletzander wrote: > On Mon, Jun 12, 2017 at 05:48:41PM +0800, Eli Qiao wrote: > > This patch adds 3 major private interface. > > > > virResctrlGetFreeCache: return free cache, default cache substract cache > > allocated. > > virResctrlSetCachetunes:

Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

2017-06-20 Thread Martin Kletzander
On Mon, Jun 12, 2017 at 05:48:41PM +0800, Eli Qiao wrote: This patch adds 3 major private interface. virResctrlGetFreeCache: return free cache, default cache substract cache allocated. virResctrlSetCachetunes: set cache banks which defined in a domain.

Re: [libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

2017-06-20 Thread Eli Qiao
hello, ping On Monday, 12 June 2017 at 5:48 PM, Eli Qiao wrote: > This patch adds 3 major private interface. > > virResctrlGetFreeCache: return free cache, default cache substract cache > allocated. > virResctrlSetCachetunes: set cache banks which defined in a domain. >

[libvirt] [PATCH RFC 2/2] Resctrl: Add uitls functions to operate sysfs resctrl

2017-06-12 Thread Eli Qiao
This patch adds 3 major private interface. virResctrlGetFreeCache: return free cache, default cache substract cache allocated. virResctrlSetCachetunes: set cache banks which defined in a domain. virResctrlRemoveCachetunes: remove cache allocation group from the