Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-07-18 Thread Daniel P. Berrange
On Mon, Jul 15, 2013 at 01:45:56PM -0600, Don Dugger wrote: [snip] We've been going back forth a while now, and I don't think we're ever going to agree on this matter. To move this forward, I'm prepared to accept an API addition that lets apps get the full list of CPU feature flags, provided

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-07-18 Thread Don Dugger
On Thu, Jul 18, 2013 at 02:37:33PM +0100, Daniel P. Berrange wrote: On Mon, Jul 15, 2013 at 01:45:56PM -0600, Don Dugger wrote: [snip] We've been going back forth a while now, and I don't think we're ever going to agree on this matter. To move this forward, I'm prepared to accept an API

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-07-15 Thread Daniel P. Berrange
On Sun, Jul 14, 2013 at 11:43:57PM -0600, Don Dugger wrote: On Mon, Jul 01, 2013 at 09:43:58AM -0600, Don Dugger wrote: 1. Ultimately, I want to remove the periodic capability update completely. The better technique is to update compute node state when the state

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-07-15 Thread Don Dugger
I think we're getting a little side tracked on how the OpenStack scheduler works (although I'll still respond to issues with my current use case). I still come back to the issue that I feel the API is not returning the proper information (ignoring how that info is used by the caller). Note that

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-07-14 Thread Don Dugger
On Mon, Jul 01, 2013 at 09:43:58AM -0600, Don Dugger wrote: On Mon, Jul 01, 2013 at 09:44:52AM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 02:26:02PM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at 09:03:55PM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-07-04 Thread Don Dugger
On Mon, Jul 01, 2013 at 09:43:58AM -0600, Don Dugger wrote: On Mon, Jul 01, 2013 at 09:44:52AM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 02:26:02PM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at 09:03:55PM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-07-01 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 02:26:02PM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at 09:03:55PM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 11:51:32AM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at 10:24:48AM +0100, Daniel P. Berrange wrote: On Thu, Jun 27, 2013 at

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-07-01 Thread Don Dugger
On Mon, Jul 01, 2013 at 09:44:52AM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 02:26:02PM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at 09:03:55PM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 11:51:32AM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-28 Thread Daniel P. Berrange
On Thu, Jun 27, 2013 at 10:35:58AM -0600, Don Dugger wrote: On Mon, Jun 17, 2013 at 10:27:36AM +0200, Jiri Denemark wrote: On Fri, Jun 14, 2013 at 12:32:35 -0600, Don Dugger wrote: On Fri, Jun 14, 2013 at 03:06:52PM +0200, Jiri Denemark wrote: I was just trying to say that it doesn't

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-28 Thread Don Dugger
On Fri, Jun 28, 2013 at 10:24:48AM +0100, Daniel P. Berrange wrote: On Thu, Jun 27, 2013 at 10:35:58AM -0600, Don Dugger wrote: On Mon, Jun 17, 2013 at 10:27:36AM +0200, Jiri Denemark wrote: On Fri, Jun 14, 2013 at 12:32:35 -0600, Don Dugger wrote: On Fri, Jun 14, 2013 at 03:06:52PM

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-28 Thread Daniel P. Berrange
On Fri, Jun 28, 2013 at 11:51:32AM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at 10:24:48AM +0100, Daniel P. Berrange wrote: On Thu, Jun 27, 2013 at 10:35:58AM -0600, Don Dugger wrote: On Mon, Jun 17, 2013 at 10:27:36AM +0200, Jiri Denemark wrote: On Fri, Jun 14, 2013 at 12:32:35

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-28 Thread Don Dugger
On Fri, Jun 28, 2013 at 09:03:55PM +0100, Daniel P. Berrange wrote: On Fri, Jun 28, 2013 at 11:51:32AM -0600, Don Dugger wrote: On Fri, Jun 28, 2013 at 10:24:48AM +0100, Daniel P. Berrange wrote: On Thu, Jun 27, 2013 at 10:35:58AM -0600, Don Dugger wrote: On Mon, Jun 17, 2013 at

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-27 Thread Don Dugger
On Mon, Jun 17, 2013 at 10:27:36AM +0200, Jiri Denemark wrote: On Fri, Jun 14, 2013 at 12:32:35 -0600, Don Dugger wrote: On Fri, Jun 14, 2013 at 03:06:52PM +0200, Jiri Denemark wrote: I was just trying to say that it doesn't provide anything more than it's supported by the host CPU, which

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-17 Thread Jiri Denemark
On Fri, Jun 14, 2013 at 12:32:35 -0600, Don Dugger wrote: On Fri, Jun 14, 2013 at 03:06:52PM +0200, Jiri Denemark wrote: I was just trying to say that it doesn't provide anything more than it's supported by the host CPU, which gives mostly no value in the context of libvirt. Can you explain

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-14 Thread Jiri Denemark
Hi Don, I'm sorry for the delay... On Fri, May 31, 2013 at 13:04:17 -0600, Don Dugger wrote: On Thu, May 30, 2013 at 01:48:32PM +0200, Jiri Denemark wrote: On Tue, May 28, 2013 at 16:11:57 -0600, Don Dugger wrote: The virConnectGetCapabilities API describes the host capabilities by

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-14 Thread Don Dugger
On Fri, Jun 14, 2013 at 03:06:52PM +0200, Jiri Denemark wrote: Hi Don, I'm sorry for the delay... NP. On Fri, May 31, 2013 at 13:04:17 -0600, Don Dugger wrote: On Thu, May 30, 2013 at 01:48:32PM +0200, Jiri Denemark wrote: On Tue, May 28, 2013 at 16:11:57 -0600, Don Dugger wrote:

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-06-06 Thread Don Dugger
Jiri- Have you had a chance to look over this email? Barring any counter examples I still think my patch is appropriate. On Fri, May 31, 2013 at 01:04:17PM -0600, Don Dugger wrote: On Thu, May 30, 2013 at 01:48:32PM +0200, Jiri Denemark wrote: On Tue, May 28, 2013 at 16:11:57 -0600, Don

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-05-31 Thread Don Dugger
On Thu, May 30, 2013 at 01:48:32PM +0200, Jiri Denemark wrote: On Tue, May 28, 2013 at 16:11:57 -0600, Don Dugger wrote: [V2 - Improve the error handling] I've opened BZ 697141 on this as I would consider it more I guess you meant BZ 967141. a bug than a feature request. Anyway, to

Re: [libvirt] [PATCH V2] Expose all CPU features in host definition

2013-05-30 Thread Jiri Denemark
On Tue, May 28, 2013 at 16:11:57 -0600, Don Dugger wrote: [V2 - Improve the error handling] I've opened BZ 697141 on this as I would consider it more I guess you meant BZ 967141. a bug than a feature request. Anyway, to re-iterate my rationale from the BZ:

[libvirt] [PATCH V2] Expose all CPU features in host definition

2013-05-28 Thread Don Dugger
[V2 - Improve the error handling] I've opened BZ 697141 on this as I would consider it more a bug than a feature request. Anyway, to re-iterate my rationale from the BZ: The virConnectGetCapabilities API describes the host capabilities