Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Fri, Apr 07, 2017 at 01:10:38PM +0100, Daniel P. Berrange wrote: On Fri, Apr 07, 2017 at 08:07:23PM +0800, Eli Qiao wrote: On Friday, 7 April 2017 at 7:06 PM, Daniel P. Berrange wrote: > On Fri, Apr 07, 2017 at 01:04:57PM +0200, Martin Kletzander wrote: > > On Fri, Apr 07, 2017 at

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

> > > > > > > > > > > > @Daniel, > > > > the enum values are same with `type` > > > > unified: 0 > > instruction: 1 > > data: 2 > > > > but scope should be both(0)/code(1)/data(2), so the attribute name will be > > 'both' and 'unified' mean the same thing. > > 'instruction'

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Fri, Apr 07, 2017 at 08:07:23PM +0800, Eli Qiao wrote: > > > On Friday, 7 April 2017 at 7:06 PM, Daniel P. Berrange wrote: > > > On Fri, Apr 07, 2017 at 01:04:57PM +0200, Martin Kletzander wrote: > > > On Fri, Apr 07, 2017 at 05:47:54PM +0800, Eli Qiao wrote: > > > > > > > > > > The name

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Friday, 7 April 2017 at 7:06 PM, Daniel P. Berrange wrote: > On Fri, Apr 07, 2017 at 01:04:57PM +0200, Martin Kletzander wrote: > > On Fri, Apr 07, 2017 at 05:47:54PM +0800, Eli Qiao wrote: > > > > > > > > The name doesn't really matter that much, 'scope' makes a bit more > > > > sense,

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Fri, Apr 07, 2017 at 01:04:57PM +0200, Martin Kletzander wrote: > On Fri, Apr 07, 2017 at 05:47:54PM +0800, Eli Qiao wrote: > > > > > > The name doesn't really matter that much, 'scope' makes a bit more > > > sense, 'type' is consistent with the cache bank specification, I'm fine > > > with

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Fri, Apr 07, 2017 at 05:47:54PM +0800, Eli Qiao wrote: The name doesn't really matter that much, 'scope' makes a bit more sense, 'type' is consistent with the cache bank specification, I'm fine with any. The big question here was if it is possible to have: And from what you say, the

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

> > The name doesn't really matter that much, 'scope' makes a bit more > sense, 'type' is consistent with the cache bank specification, I'm fine > with any. The big question here was if it is possible to have: > > > > > > > And from what you say, the simple answer is "yes". So we need to

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Fri, Apr 07, 2017 at 09:38:39AM +0800, Eli Qiao wrote: On Thursday, 6 April 2017 at 8:46 PM, Martin Kletzander wrote: On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: > This patch is based on Martin's cache branch. > > This patch amends the cache bank capability as follow: It

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Fri, Apr 07, 2017 at 09:51:02AM +0800, Eli Qiao wrote: On Thursday, 6 April 2017 at 9:04 PM, Martin Kletzander wrote: On Thu, Apr 06, 2017 at 01:25:35PM +0100, Daniel P. Berrange wrote: > On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: > > This patch is based on Martin's cache

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Thursday, 6 April 2017 at 9:04 PM, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 01:25:35PM +0100, Daniel P. Berrange wrote: > > On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: > > > This patch is based on Martin's cache branch. > > > > > > This patch amends the cache bank

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Thursday, 6 April 2017 at 8:46 PM, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: > > This patch is based on Martin's cache branch. > > > > This patch amends the cache bank capability as follow: > > It helps a lot if you wait for a conclusion on a

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 01:25:35PM +0100, Daniel P. Berrange wrote: On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: This patch is based on Martin's cache branch. This patch amends the cache bank capability as follow: Why do we need to report 'type' on both bank &

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 02:46:10PM +0200, Martin Kletzander wrote: > On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: > > This patch is based on Martin's cache branch. > > > > This patch amends the cache bank capability as follow: > > > > It helps a lot if you wait for a conclusion on

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: This patch is based on Martin's cache branch. This patch amends the cache bank capability as follow: It helps a lot if you wait for a conclusion on a patch before sending another version as soon as you can change one line.

Re: [libvirt] [PATCH V3] Expose resource control capabilites on cache bank

On Thu, Apr 06, 2017 at 08:20:56PM +0800, Eli Qiao wrote: > This patch is based on Martin's cache branch. > > This patch amends the cache bank capability as follow: > > > > > Why do we need to report 'type' on both bank & control elements. Are they really expected to have different

[libvirt] [PATCH V3] Expose resource control capabilites on cache bank

This patch is based on Martin's cache branch. This patch amends the cache bank capability as follow: Along with vircaps2xmltest case updated. Signed-off-by: Eli Qiao --- src/conf/capabilities.c | 120