Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-22 Thread Zeeshan Ali (Khattak)
On Tue, Jul 21, 2015 at 4:09 PM, Daniel P. Berrange berra...@redhat.com wrote: On Tue, Jul 21, 2015 at 03:56:54PM +0100, Zeeshan Ali (Khattak) wrote: On Tue, Jul 21, 2015 at 3:20 PM, Daniel P. Berrange berra...@redhat.com wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-21 Thread Zeeshan Ali (Khattak)
On Tue, Jul 21, 2015 at 3:20 PM, Daniel P. Berrange berra...@redhat.com wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make use of the virNetworkGetDHCPLeases API conditional too, rather than

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-21 Thread Christophe Fergeau
Hi, On Tue, Jul 21, 2015 at 03:20:03PM +0100, Daniel P. Berrange wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make use of the virNetworkGetDHCPLeases API conditional too, rather than requiring

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-21 Thread Daniel P. Berrange
On Tue, Jul 21, 2015 at 04:55:15PM +0200, Christophe Fergeau wrote: Hi, On Tue, Jul 21, 2015 at 03:20:03PM +0100, Daniel P. Berrange wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make use of

Re: [libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-21 Thread Daniel P. Berrange
On Tue, Jul 21, 2015 at 03:56:54PM +0100, Zeeshan Ali (Khattak) wrote: On Tue, Jul 21, 2015 at 3:20 PM, Daniel P. Berrange berra...@redhat.com wrote: Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make

[libvirt] [PATCH glib] Make use of DHCP API conditionally compiled

2015-07-21 Thread Daniel P. Berrange
Previously the use of virDomainOpenGraphicsFD API from libvirt 1.2.8 was made to be conditionally compiled. Given this past practice, make use of the virNetworkGetDHCPLeases API conditional too, rather than requiring newer libvirt. --- configure.ac | 6 ++-