Re: [libvirt] [PATCH go] domain.go: construct cpumaps correctly for CPU pinning verbs

2017-02-14 Thread Leonid Podolny
Please ignore this patch, I failed to see that in 2 out of 4 locations we already are looking at the value. I'm sending a better patch instead. On Tue, Feb 14, 2017 at 4:48 PM, Leonid Podolny wrote: > In PinVcpu(), PinVcpuFlags(), PinEmulator() and PinIOThread() there is >

[libvirt] [PATCH go] domain.go: construct cpumaps correctly for CPU pinning verbs

2017-02-14 Thread Leonid Podolny
In PinVcpu(), PinVcpuFlags(), PinEmulator() and PinIOThread() there is an almost identical code that converts []bool into a bitmask. It calculates the location in the bitmask and then sets it always to 1, instead of looking at the actual bool value. --- domain.go | 16 1 file