Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: > diff --git a/guests/vars/projects/virt-viewer.yml > b/guests/vars/projects/virt-viewer.yml > index 6f3dbf9..85d1589 100644 > --- a/guests/vars/projects/virt-viewer.yml > +++ b/guests/vars/projects/virt-viewer.yml > @@ -6,5 +6,29 @@

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Fri, Apr 13, 2018 at 02:36:57PM +0200, Andrea Bolognani wrote: > On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: > [...] > > + mingw32-gtk-vnc: > > +FedoraRawhide: mingw32-gtk-vnc > > This (and the corresponding mingw64 entry) will drag in the version > of the library based

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Fri, Apr 13, 2018 at 03:40:49PM +0200, Andrea Bolognani wrote: > On Fri, 2018-04-13 at 14:25 +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 13, 2018 at 03:05:10PM +0200, Andrea Bolognani wrote: > > > No, wait, actually its native variant is, but the same is true for > > > the Adwaita icon

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Fri, 2018-04-13 at 14:25 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 13, 2018 at 03:05:10PM +0200, Andrea Bolognani wrote: > > No, wait, actually its native variant is, but the same is true for > > the Adwaita icon theme. Weird. I don't see how we would need one of > > them to be native and

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Fri, 2018-04-13 at 14:28 +0100, Daniel P. Berrangé wrote: > On Fri, Apr 13, 2018 at 03:24:09PM +0200, Andrea Bolognani wrote: > > > + - mingw32-glib2 > > > > Forgot to mention: mingw*-glib2 is not necessary here based on our > > discussion, as it's already required to build libvirt-glib :) >

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Fri, Apr 13, 2018 at 03:24:09PM +0200, Andrea Bolognani wrote: > On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: > > diff --git a/guests/vars/projects/virt-viewer.yml > > b/guests/vars/projects/virt-viewer.yml > > index 6f3dbf9..85d1589 100644 > > ---

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Fri, Apr 13, 2018 at 03:05:10PM +0200, Andrea Bolognani wrote: > On Fri, 2018-04-13 at 13:44 +0100, Daniel P. Berrangé wrote: > > > Because of the missing dependencies mentioned below, you also need > > > > > > mingw32-hicolor-icon-theme: > > > FedoraRawhide: mingw32-hicolor-icon-theme >

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Fri, 2018-04-13 at 13:44 +0100, Daniel P. Berrangé wrote: > > Because of the missing dependencies mentioned below, you also need > > > > mingw32-hicolor-icon-theme: > > FedoraRawhide: mingw32-hicolor-icon-theme > > There's no such package AFAIK There sure is: $ dnf info

Re: [libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

On Thu, 2018-04-12 at 15:28 +0100, Daniel P. Berrangé wrote: [...] > + mingw32-gtk-vnc: > +FedoraRawhide: mingw32-gtk-vnc This (and the corresponding mingw64 entry) will drag in the version of the library based on GTK+ 2 rather than the one based on GTK+ 3, which is not what we want. It

[libvirt] [PATCH jenkins-ci 2/2] Enable mingw build for virt-viewer project

Signed-off-by: Daniel P. Berrangé --- guests/vars/mappings.yml | 66 guests/vars/projects/virt-viewer.yml | 24 + projects/virt-viewer.yaml| 4 +++ 3 files changed, 94 insertions(+) diff --git